-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mappings to external vocabularies/ontologies are not correctly added #241
Comments
The reason for the problem is the way the sheets "Concepts" and "Additional Concept Features" are parsed. Both are read in parallel row by row. So the same IRI must be present in the same row in both sheets. Whenever the order of rows is different, the mappings are assigned wrongly because the mapping happens in principle by row and not by IRI. This behavior is inherited from the code we built upon and it should of course change. The idea is to use the IRIs as keys to link the rows in both sheets correctly. Then it is also possible to only add the IRIs that you want to provide mappings for. Moreover, both sheets could use completely different ordering. This solution would not even break backward compatibility. |
In nfdi4cat/voc4cat#117 we wanted to add a
skos:broader
mapping via theAdditional Concept Features
sheet.We defined three mappings:
However, the mappings appeared in wrong turtle files (for the wrong concept):
The other SOSA mapping were added (also wrongly) to voc4cat_0000019 and voc4cat:0007037. The three concepts to which the mapping was added were in the first three lines of the
Concepts
sheet. Obviously the first column inAdditional Concept Features
sheet is not correctly used as key to generate the mapping for the given concept.The text was updated successfully, but these errors were encountered: