-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rnafusion v1.0.2 #78
Merged
rnafusion v1.0.2 #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I anyways like the numeric ones better ;-) |
##:rotating_light: Buil log output: Branch indexing Connecting to https://api.github.com using nf-core-bot/****** (nf-core) Obtained Jenkinsfile from eca7b53+d32090720b79a2e43d36977753ea5102750c8727 (e9407e0) Running in Durability level: MAX_SURVIVABILITY [Pipeline] Start of Pipeline [Pipeline] node Running on ship-1 in /share/jenkins_home/workspace/nf-core_rnafusion_PR-78 [Pipeline] { [Pipeline] stage [Pipeline] { (Declarative: Checkout SCM) [Pipeline] checkout using credential 3d82ac34-e01a-4592-a628-ce6732c445a3 Cloning the remote Git repository Cloning with configured refspecs honoured and without tags Cloning repository https://github.com/nf-core/rnafusion.git > git init /share/jenkins_home/workspace/nf-core_rnafusion_PR-78 # timeout=10 Fetching upstream changes from https://github.com/nf-core/rnafusion.git > git --version # timeout=10 using GIT_ASKPASS to set credentials nf-core > git fetch --no-tags --progress https://github.com/nf-core/rnafusion.git +refs/pull/78/head:refs/remotes/origin/PR-78 +refs/heads/master:refs/remotes/origin/master Fetching without tags Merging remotes/origin/master commit d320907 into PR head commit eca7b53 > git config remote.origin.url https://github.com/nf-core/rnafusion.git # timeout=10 > git config --add remote.origin.fetch +refs/pull/78/head:refs/remotes/origin/PR-78 # timeout=10 > git config --add remote.origin.fetch +refs/heads/master:refs/remotes/origin/master # timeout=10 > git config remote.origin.url https://github.com/nf-core/rnafusion.git # timeout=10 Fetching upstream changes from https://github.com/nf-core/rnafusion.git using GIT_ASKPASS to set credentials nf-core > git fetch --no-tags --progress https://github.com/nf-core/rnafusion.git +refs/pull/78/head:refs/remotes/origin/PR-78 +refs/heads/master:refs/remotes/origin/master > git config core.sparsecheckout # timeout=10 > git checkout -f eca7b53 > git merge d320907 # timeout=10 Merge succeeded, producing d602632e3a919751dd30ab9dcd41514175998772 Checking out Revision d602632e3a919751dd30ab9dcd41514175998772 (PR-78) Commit message: "Merge commit 'd32090720b79a2e43d36977753ea5102750c8727' into HEAD" First time build. Skipping changelog. > git rev-parse HEAD^{commit} # timeout=10 > git config core.sparsecheckout # timeout=10 > git checkout -f d602632e3a919751dd30ab9dcd41514175998772 [Pipeline] } [Pipeline] // stage [Pipeline] withEnv [Pipeline] { [Pipeline] withCredentials Masking only exact matches of $JENKINS_API or $JENKINS_API_USR or $JENKINS_API_PSW [Pipeline] { [Pipeline] withEnv [Pipeline] { [Pipeline] stage [Pipeline] { (Setup environment) [Pipeline] sh + pip install nf-core Requirement already satisfied: nf-core in /home//anaconda3/lib/python3.7/site-packages (1.6) Requirement already satisfied: tabulate in /home//anaconda3/lib/python3.7/site-packages (from nf-core) (0.8.3) Requirement already satisfied: click in /home//anaconda3/lib/python3.7/site-packages (from nf-core) (7.0) Requirement already satisfied: jsonschema in /home//anaconda3/lib/python3.7/site-packages (from nf-core) (2.6.0) Requirement already satisfied: requests in /home//anaconda3/lib/python3.7/site-packages (from nf-core) (2.21.0) Requirement already satisfied: cookiecutter in /home//anaconda3/lib/python3.7/site-packages (from nf-core) (1.6.0) Requirement already satisfied: requests-cache in /home//anaconda3/lib/python3.7/site-packages (from nf-core) (0.5.0) Requirement already satisfied: pyyaml in /home//anaconda3/lib/python3.7/site-packages (from nf-core) (3.13) Requirement already satisfied: GitPython in /home//anaconda3/lib/python3.7/site-packages (from nf-core) (2.1.11) Requirement already satisfied: urllib3<1.25,>=1.21.1 in /home//anaconda3/lib/python3.7/site-packages (from requests->nf-core) (1.24.1) Requirement already satisfied: certifi>=2017.4.17 in /home//anaconda3/lib/python3.7/site-packages (from requests->nf-core) (2018.11.29) Requirement already satisfied: idna<2.9,>=2.5 in /home//anaconda3/lib/python3.7/site-packages (from requests->nf-core) (2.8) Requirement already satisfied: chardet<3.1.0,>=3.0.2 in /home//anaconda3/lib/python3.7/site-packages (from requests->nf-core) (3.0.4) Requirement already satisfied: binaryornot>=0.2.0 in /home//anaconda3/lib/python3.7/site-packages (from cookiecutter->nf-core) (0.4.4) Requirement already satisfied: whichcraft>=0.4.0 in /home//anaconda3/lib/python3.7/site-packages (from cookiecutter->nf-core) (0.5.2) Requirement already satisfied: jinja2>=2.7 in /home//anaconda3/lib/python3.7/site-packages (from cookiecutter->nf-core) (2.10) Requirement already satisfied: future>=0.15.2 in /home//anaconda3/lib/python3.7/site-packages (from cookiecutter->nf-core) (0.17.1) Requirement already satisfied: jinja2-time>=0.1.0 in /home//anaconda3/lib/python3.7/site-packages (from cookiecutter->nf-core) (0.2.0) Requirement already satisfied: poyo>=0.1.0 in /home//anaconda3/lib/python3.7/site-packages (from cookiecutter->nf-core) (0.4.2) Requirement already satisfied: gitdb2>=2.0.0 in /home//anaconda3/lib/python3.7/site-packages (from GitPython->nf-core) (2.0.5) Requirement already satisfied: MarkupSafe>=0.23 in /home//anaconda3/lib/python3.7/site-packages (from jinja2>=2.7->cookiecutter->nf-core) (1.1.0) Requirement already satisfied: arrow in /home//anaconda3/lib/python3.7/site-packages (from jinja2-time>=0.1.0->cookiecutter->nf-core) (0.13.1) Requirement already satisfied: smmap2>=2.0.0 in /home//anaconda3/lib/python3.7/site-packages (from gitdb2>=2.0.0->GitPython->nf-core) (2.0.5) Requirement already satisfied: python-dateutil in /home//anaconda3/lib/python3.7/site-packages (from arrow->jinja2-time>=0.1.0->cookiecutter->nf-core) (2.7.5) Requirement already satisfied: six>=1.5 in /home/****/anaconda3/lib/python3.7/site-packages (from python-dateutil->arrow->jinja2-time>=0.1.0->cookiecutter->nf-core) (1.12.0) [Pipeline] sh + docker pull nfcore/rnafusion:1.0.2 Error response from daemon: manifest for nfcore/rnafusion:1.0.2 not found [Pipeline] } [Pipeline] // stage [Pipeline] stage [Pipeline] { (Lint markdown) Stage "Lint markdown" skipped due to earlier failure(s) [Pipeline] } [Pipeline] // stage [Pipeline] stage [Pipeline] { (Build) Stage "Build" skipped due to earlier failure(s) [Pipeline] } [Pipeline] // stage [Pipeline] stage [Pipeline] { (Declarative: Post Actions) [Pipeline] script [Pipeline] { [Pipeline] sh |
maxulysse
reviewed
May 14, 2019
maxulysse
reviewed
May 14, 2019
apeltzer
requested changes
May 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some missing points, mostly good 👍
Can’t accept on mobile, will do this tomorrow morning |
apeltzer
approved these changes
May 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was supposed to be
1.0.1-FIX
. Had to bump the version to1.0.2
.