Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template missing channels for fastqc and multiqc #333

Closed
matq007 opened this issue May 15, 2019 · 4 comments
Closed

Template missing channels for fastqc and multiqc #333

matq007 opened this issue May 15, 2019 · 4 comments
Assignees
Labels
template nf-core pipeline/component template
Milestone

Comments

@matq007
Copy link
Member

matq007 commented May 15, 2019

The cookiecutter template is missing channels for both fastqc and multiqc in environment.yml.

@matq007 matq007 added the template nf-core pipeline/component template label May 15, 2019
@matq007 matq007 self-assigned this May 15, 2019
matq007 added a commit to matq007/tools that referenced this issue May 15, 2019
@drpatelh
Copy link
Member

@matq007 I think we agreed that not to pin the channels if it can be avoided:
nf-core/methylseq#74 (comment)

Is this what you meant?

@matq007
Copy link
Member Author

matq007 commented May 15, 2019

Ah interesting, I have different info from @apeltzer. Discussion here.

@drpatelh
Copy link
Member

Maybe we didnt ALL agree then 😆 Should probably revisit the discussion...

Another example where I was under the same impression:
nf-core/atacseq#23 (comment)

@apeltzer
Copy link
Member

So there is a couple of things with this that we should probably discuss out a bit. The discussion started here somehow (maybe earlier occasions available too, but thats the one I remember):

nf-core/cookiecutter#45

It came back, when this here started due to slower conda resolving issues:

bioconda/bioconda-recipes#13774

I guess we should just define what we want and keep the template set like this later - and then maybe make a comment why we settled it like this 👍 My impression was to have the prefixes for (conda-forge/bioconda::) doesn't really harm and makes it more explicit where packages are coming from (which I like a lot).

@apeltzer apeltzer added this to the 1.7 milestone May 16, 2019
apeltzer added a commit that referenced this issue Jun 28, 2019
specified conda channels in template (#333)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
template nf-core pipeline/component template
Projects
None yet
Development

No branches or pull requests

3 participants