Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contacts): implement single column layout #3315

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Apr 18, 2023

Fix #3305

grafik

TODO

@st3iny st3iny added enhancement New feature or request 2. developing Work in progress design Related to the design labels Apr 18, 2023
@st3iny st3iny self-assigned this Apr 18, 2023
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: -1.88 ⚠️

Comparison is base (e24fb28) 1.87% compared to head (b0d044e) 0.00%.

❗ Current head b0d044e differs from pull request most recent head 7a7a95e. Consider uploading reports for the commit 7a7a95e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              main   #3315      +/-   ##
==========================================
- Coverage     1.87%   0.00%   -1.88%     
  Complexity     272     272              
==========================================
  Files          112      25      -87     
  Lines         5922     824    -5098     
  Branches      1379       0    -1379     
==========================================
- Hits           111       0     -111     
+ Misses        5697     824    -4873     
+ Partials       114       0     -114     

see 87 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@st3iny st3iny marked this pull request as ready for review April 20, 2023 11:43
@st3iny st3iny added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 20, 2023
@JohannesGGE

This comment was marked as resolved.

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works!

Edit: happen on main too. Ignore. #3334

@st3iny
Copy link
Member Author

st3iny commented Apr 24, 2023

I fixed the issue found by Johannes.

grafik

@st3iny st3iny force-pushed the enh/single-column-layout branch from a6eaf3d to 921b211 Compare April 24, 2023 12:28
@st3iny
Copy link
Member Author

st3iny commented Apr 24, 2023

I rebased and fixed conflicts. The "Add more info" buttons stays below the property list for now. There is another PR to move the buttons around (to the second column if possible).

grafik

@st3iny st3iny force-pushed the enh/single-column-layout branch from 921b211 to 7a7a95e Compare April 24, 2023 12:32
@ChristophWurst ChristophWurst merged commit 40447df into main Apr 24, 2023
@ChristophWurst ChristophWurst deleted the enh/single-column-layout branch April 24, 2023 15:36
@st3iny st3iny added this to the v5.3.0 milestone Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Related to the design enhancement New feature or request feature: contacts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Single column layout
3 participants