Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contacts): adjust header to single column layout #3338

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Apr 25, 2023

Fix #3325

Followup to #3315

Please ignore the borders around the read only input fields below the header. This is just a visual regression from #3315. The inputs are read-only/disabled but are rendered with a (slightly transparent) border.

Read-only mode is tracked in #3284.

Desktop

read-write read-only
contact-details-rw-after contact-details-ro-after

Mobile

read-write read-only
contact-details-mobile-rw-after contact-details-mobile-ro-after

@st3iny st3iny self-assigned this Apr 25, 2023
@st3iny st3iny added enhancement New feature or request 3. to review Waiting for reviews design Related to the design feature: contacts labels Apr 25, 2023
@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: -1.88 ⚠️

Comparison is base (5e1da1f) 1.87% compared to head (9dc2a0e) 0.00%.

❗ Current head 9dc2a0e differs from pull request most recent head f348b2e. Consider uploading reports for the commit f348b2e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              main   #3338      +/-   ##
==========================================
- Coverage     1.87%   0.00%   -1.88%     
  Complexity     272     272              
==========================================
  Files          112      25      -87     
  Lines         5932     824    -5108     
  Branches      1389       0    -1389     
==========================================
- Hits           111       0     -111     
+ Misses        5707     824    -4883     
+ Partials       114       0     -114     

see 87 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

Copy link
Contributor

@JohannesGGE JohannesGGE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@ChristophWurst ChristophWurst merged commit fc8e75e into main Apr 25, 2023
@ChristophWurst ChristophWurst deleted the enh/contact-details-header branch April 25, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Related to the design enhancement New feature or request feature: contacts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve contact detail header
3 participants