Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContactDetails: "TypeError: this.localContact is undefined" #3334

Closed
ChristophWurst opened this issue Apr 24, 2023 · 0 comments · Fixed by #3349
Closed

ContactDetails: "TypeError: this.localContact is undefined" #3334

ChristophWurst opened this issue Apr 24, 2023 · 0 comments · Fixed by #3349
Assignees
Labels
3. to review Waiting for reviews bug Something isn't working feature: contacts regression Regression of a previous working feature technical debt

Comments

@ChristophWurst
Copy link
Member

Describe the bug

App throws an error because the localContact is undefined at component creation time and used in a computed prop without an undefined check

Steps to reproduce

  1. Add contacts
  2. Reload the page
  3. Watch the console

Expected behavior

No errors

Actual behavior

[Vue warn]: Error in render: "TypeError: this.localContact is undefined"

found in

---> <DetailsHeader> at src/components/DetailsHeader.vue
       <NcAppContentDetails>
         <ContactDetails> at src/components/ContactDetails.vue
           <NcAppContent>
             <ContactsContent> at src/components/AppContent/ContactsContent.vue
               <Content>
                 <Contacts> at src/views/Contacts.vue
                   <ContactsRoot> at src/ContactsRoot.vue
                     <Root>

and

TypeError: this.localContact is undefined
    excludeFromBirthdayLabel ContactDetails.vue:486
    VueJS 4
    fn ContactDetails.vue:319
    VueJS 2
    render DetailsHeader.vue:49
    node_modules contacts-main.js:41941
vue.runtime.esm.js:1897

Contact version

4

Operating system

No response

PHP engine version

None

Web server

None

Database

None

Additional info

Likely introduced with #3009.

👀 @sylvainmetayer

@ChristophWurst ChristophWurst added bug Something isn't working 1. to develop Accepted and waiting to be taken care of regression Regression of a previous working feature feature: contacts technical debt labels Apr 24, 2023
@st3iny st3iny added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Apr 28, 2023
@st3iny st3iny self-assigned this Apr 28, 2023
@st3iny st3iny moved this to 🧭 Planning evaluation (dont pick) in 💌 📅 👥 Groupware team Apr 28, 2023
@st3iny st3iny moved this from 🧭 Planning evaluation (dont pick) to 🏗️ In progress in 💌 📅 👥 Groupware team Apr 28, 2023
@st3iny st3iny added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 28, 2023
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 💌 📅 👥 Groupware team Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: contacts regression Regression of a previous working feature technical debt
Projects
Development

Successfully merging a pull request may close this issue.

2 participants