Fix Firefox crash (marketo forms) #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerelmiller
approved these changes
Sep 23, 2020
|
🎉 This PR is included in version 1.21.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When Firefox has "Strict" content blocked enabled, the developer site would crash because the browser removed
MktoForms2from thewindowobject. This PR checks to make sure it's available (and is loaded) before adding the form to the page.Reviewer Notes
I initially tried to create an ErrorBoundary component, but the issue was coming from
gatsby-nodeinitially. At some point, we should consider building in some boundaries so the site can partially function in the event of errors.Related Issue(s) / Ticket(s)