Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix marketo content blocking issue. #775

Conversation

curious-attempt-bunny
Copy link

@curious-attempt-bunny curious-attempt-bunny commented Sep 18, 2020

Description

With Content Blocking enabled in Firefox the page vanishes in prod, and looks like this locally:
Pasted_Image_9_18_20__1_06_PM

Reviewer Notes

Use Firefox, enabled content blocking. Very before and after.

Related Issue(s) / Ticket(s)

This is a JIRA for this. Not sure what it is.

Screenshot(s)

I can't see amplify's failure, this is what it looks like for me after the fix:
image

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Merlyn Albery-Speyer seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@curious-attempt-bunny
Copy link
Author

I signed the CLA and clicked recheck. 🤷 Seems odd to need it as I believe I'm a newrelic org member.

@nr-opensource-bot
Copy link
Contributor

🎉 This issue has been resolved in version 1.21.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants