Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marketo breaks site for Firefox users with ad-blocker enabled #774

Closed
zstix opened this issue Sep 18, 2020 · 3 comments · Fixed by #780
Closed

Marketo breaks site for Firefox users with ad-blocker enabled #774

zstix opened this issue Sep 18, 2020 · 3 comments · Fixed by #780
Assignees
@zstix
Labels
bug Something isn't working P3 Priority 3 released sustaining

Comments

@zstix
Copy link
Contributor

zstix commented Sep 18, 2020

Description

Marketo (used for the Nerd Days signup form) throws an error that brings down the site if an ad-blocker is enabled in Firefox.

ReferenceError: MktoForms2 is not defined

Steps to Reproduce

  1. In Firefox settings, under "Enhanced Tracking Protection", choose "Strict".
  2. Navigate to the developer site.

Screenshot(s)

image
@zstix zstix added bug Something isn't working P3 Priority 3 sustaining labels Sep 18, 2020
@jpvajda
Copy link
Contributor

jpvajda commented Sep 18, 2020

Merlyn Albery-Speyer offered to submit a PR to fix this.

@zstix
Copy link
Contributor Author

zstix commented Sep 18, 2020

We may want to wrap the site in an Error Boundary to more gracefully handle any error on the site.

@zstix zstix self-assigned this Sep 23, 2020
@zstix zstix mentioned this issue Sep 23, 2020
Merged
@nr-opensource-bot
Copy link
Contributor

🎉 This issue has been resolved in version 1.21.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zstix zstix

Labels
bug Something isn't working P3 Priority 3 released sustaining
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Firefox crash (marketo forms) newrelic/developer-website
3 participants
@jpvajda @zstix @nr-opensource-bot