Add support for Direct Get API with key in subject

[mtmk]

Proposed solution for #770

• fixes Subject in GetDirectAsync differs across client library implementations #770

[garrett-sutton]

@mtmk This is great. Thanks for hopping on it so quickly. This approach will work for our use case.

[garrett-sutton]

potential for future

One additional piece that I had to think about for a little bit. In my use case's current state, we rely on the extensions that are defined in src/NATS.Client.KeyValueStore/NatsClientExtensions.cs to create an INatsKVContext . With the enhancements that are proposed as part of this PR we'll need to transition to setting up the INatsKVContext directly (rather than via the extension off of the INatsConnection).

Like I said in my other comment, I think the current proposal is good and we are OK with setting up the INatsKVConext directly though. This is largely just food for thought.

[mtmk]

One additional piece that I had to think about for a little bit. In my use case's current state, we rely on the extensions that are defined in src/NATS.Client.KeyValueStore/NatsClientExtensions.cs to create an INatsKVContext . With the enhancements that are proposed as part of this PR we'll need to transition to setting up the INatsKVContext directly (rather than via the extension off of the INatsConnection).

@garrett-sutton that is a good point. I think we have a similar case for JetStream as well off the top of my head. I'll put that in a separate PR.

[scottf]

LGTM