Added an ability to specify pool size with a callback using IServiceProvider (fixed&signed)#757
Merged
Merged
Conversation
Member
|
please merge main. fixes build. |
…unc_fixed_and_signed
uhfath
force-pushed
the
pool_size_func_fixed_and_signed
branch
from
March 8, 2025 07:52
05bd88e to
98c14e6
Compare
Contributor
Author
|
Done. |
Member
|
cc @rickdotnet |
mtmk
approved these changes
Mar 11, 2025
mtmk
added a commit
that referenced
this pull request
Mar 12, 2025
* Add support for Direct Get API with key in subject (#771) * Add Metadata to KV Bucket (#741) * Added an ability to specify pool size with a callback using IServiceProvider (#757) * Add NatsPayloadTooLargeException class (#761) * Make the parameter-less StreamConfig constructor public (#768) * Release 2.5.10-preview.1 (#766) * Fix reconnect getting stuck (#758) * Fix task tracking (#764) * Fix Windows build (#765)
Merged
mtmk
added a commit
that referenced
this pull request
Mar 12, 2025
* Add support for Direct Get API with key in subject (#771) * Add Metadata to KV Bucket (#741) * Added an ability to specify pool size with a callback using IServiceProvider (#757) * Add NatsPayloadTooLargeException class (#761) * Make the parameter-less StreamConfig constructor public (#768) * Release 2.5.10-preview.1 (#766) * Fix reconnect getting stuck (#758) * Fix task tracking (#764) * Fix Windows build (#765)
This was referenced Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When initializing NATS using
IServiceCollection.AddNatsClientone has to specify a pool size in a callback, which doesn't support passingIServiceProvider. This involves setting pool size upfront as a constant or reading it fromIConfigurationdirectly with something likeIConfiguration.GetSection(...).Get<...>().This PR retains an ability to specify pool size constantly as it is now without breaking changes. And also adds an ability to use
IServiceProviderwhich helps in cases where pool size is defined in one of app options. Something like:But because of this there will be no more
SingleConnectionFactoryandPooledConnectionFactorywill be always used even if pool size is 1.This might come with a performance impact in very high load cases since there is another layer of delegates added.
But it should be negligible.