Skip to content

Add NatsPayloadTooLargeException class#761

Merged
mtmk merged 3 commits into
nats-io:mainfrom
aDisplayName:pr/create-natspayloadtoolargeexception
Mar 11, 2025
Merged

Add NatsPayloadTooLargeException class#761
mtmk merged 3 commits into
nats-io:mainfrom
aDisplayName:pr/create-natspayloadtoolargeexception

Conversation

@aDisplayName

Copy link
Copy Markdown
Contributor

Add NatsPayloadTooLargeException class to support special handling regarding excessive payload when writing to server.

Fix #759

@mtmk

mtmk commented Mar 5, 2025

Copy link
Copy Markdown
Member

thanks @aDisplayName although it's a simple one should we add a test?

@aDisplayName

aDisplayName commented Mar 5, 2025

Copy link
Copy Markdown
Contributor Author

@mtmk , I realized there is already a related test existed. It has now been updated.

@mtmk

mtmk commented Mar 7, 2025

Copy link
Copy Markdown
Member

please merge main. fixes build.

@aDisplayName

aDisplayName commented Mar 7, 2025

Copy link
Copy Markdown
Contributor Author

@mtmk , Changes in main has been merged.

Not sure the root cause of the test failure, doesn't seem to related to my change. Could be timing issue?

@mtmk

mtmk commented Mar 7, 2025

Copy link
Copy Markdown
Member

thanks @aDisplayName. no worries failing test is probably a flapper. there was a problem with the windows tests i wanted that fixed. I need to double check the merge but other than that it should be all good.

@mtmk
mtmk force-pushed the pr/create-natspayloadtoolargeexception branch from 2edbda1 to 4e772b4 Compare March 11, 2025 20:30

@mtmk mtmk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @aDisplayName

@mtmk
mtmk merged commit 0288134 into nats-io:main Mar 11, 2025
mtmk added a commit that referenced this pull request Mar 12, 2025
* Add support for Direct Get API with key in subject (#771)
* Add Metadata to KV Bucket (#741)
* Added an ability to specify pool size with a callback using IServiceProvider (#757)
* Add NatsPayloadTooLargeException class (#761)
* Make the parameter-less StreamConfig constructor public (#768)
* Release 2.5.10-preview.1 (#766)
* Fix reconnect getting stuck (#758)
* Fix task tracking (#764)
* Fix Windows build (#765)
@mtmk mtmk mentioned this pull request Mar 12, 2025
mtmk added a commit that referenced this pull request Mar 12, 2025
* Add support for Direct Get API with key in subject (#771)
* Add Metadata to KV Bucket (#741)
* Added an ability to specify pool size with a callback using IServiceProvider (#757)
* Add NatsPayloadTooLargeException class (#761)
* Make the parameter-less StreamConfig constructor public (#768)
* Release 2.5.10-preview.1 (#766)
* Fix reconnect getting stuck (#758)
* Fix task tracking (#764)
* Fix Windows build (#765)
@mtmk mtmk added this to the v2.5.11 milestone Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide NatsPayloadTooLargeException to handle payload size related situation

2 participants