Add AllowBatchPublish stream config field#1120
Merged
Merged
Conversation
Contributor
|
Claude finished @mtmk's task in 1m 55s —— View job PR Review: Add AllowBatchPublish stream config field
Review SummaryThe change is minimal and well-structured. No correctness, security, or performance issues found.
One minor observation: the LGTM. |
This was referenced May 1, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
AllowBatchPublishfield onStreamConfig(JSONallow_batched), required by streams that opt in to fast ingest batch publishing per ADR-50. Matches the field added in nats.go (#2052) and nats.js (#379). Server-side support requires nats-server v2.14.0+. The fast-ingest publisher itself will live in orbit.net alongside the existing atomic batch publisher.