You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Preview release bumping version to 2.8.0-preview.2. Adds nats-server v2.14 support for fast-ingest batch publishing via the new AllowBatchPublish field on StreamConfig (ADR-50). Also picks up Pin ID handling fix for duplicate status headers, README rewrite, and CI/test flake fixes.
This is a release bump PR (version.txt: 2.8.0-preview.1 → 2.8.0-preview.2). The one-line diff is trivially correct. I reviewed the key changes included in this release that are already in the branch.
WhenWritingDefault is correct for a bool — false won't be serialized, matching the server's field-absence semantics. The test at ManageStreamTest.cs:300 correctly carries [SkipIfNatsServer(versionEarlierThan: "2.14")].
Minor observation: The JSON property name allow_batched is slightly inconsistent with the existing AllowAtomicPublish → allow_atomic pattern (one uses an adjective, the other uses a past participle). This is presumably dictated by the server-side ADR-50 field name and not something the client controls, but worth a quick cross-check against the server spec if it hasn't been done already.
Pin ID fix (NatsJSExtensionsInternal.cs, NatsJSConsume.cs:459, NatsJSFetch.cs:292)
TrySetPinIdFromHeaders is correctly invoked only in the regular-message branch (the else path after all status-header checks), preventing spurious pin ID overwrite from idle-heartbeat or other status responses. The lock-based GetPinId/SetPinId in NatsJSConsumer.cs:326-343 is correct for the read-heavy, infrequent-write pattern here.
TryGetLastValue uses values[^1] which is fine — in practice a Nats-Pin-Id header will have exactly one value, but taking the last is the safe choice for multi-value headers.
Version bump
2.8.0-preview.1 → 2.8.0-preview.2 is correct and matches the PR title and description.
Overall: No correctness or security issues found. The release looks good to merge once CI passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview release bumping version to 2.8.0-preview.2. Adds nats-server v2.14 support for fast-ingest batch publishing via the new
AllowBatchPublishfield onStreamConfig(ADR-50). Also picks up Pin ID handling fix for duplicate status headers, README rewrite, and CI/test flake fixes.