Skip to content

Release v3.10 - #853

Merged
levb merged 2 commits into
release_3_10from
release_3_10_PR
Feb 28, 2025
Merged

Release v3.10#853
levb merged 2 commits into
release_3_10from
release_3_10_PR

Conversation

@levb

@levb levb commented Feb 28, 2025

Copy link
Copy Markdown
Collaborator

Release notes:

Added

Fixed

Non-code changes

New Contributors

Full Changelog: v3.9.0...v3.10

@levb
levb requested review from Jarema, kozlovic and mtmk February 28, 2025 16:27
@codecov

codecov Bot commented Feb 28, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release_3_10@f356e63). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff               @@
##             release_3_10     #853   +/-   ##
===============================================
  Coverage                ?   70.40%           
===============================================
  Files                   ?       47           
  Lines                   ?    15410           
  Branches                ?     3161           
===============================================
  Hits                    ?    10849           
  Misses                  ?     1517           
  Partials                ?     3044           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@levb

levb commented Feb 28, 2025

Copy link
Copy Markdown
Collaborator Author

Please see #852 for the docs changes that will be used for gh-pages. I could've just added them to this PR but 0/5 it's cleaner to have them separate since it's a lot of files. LMK if you think otherwise?

@kozlovic kozlovic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we check on the version required number?

Comment thread CMakeLists.txt
set(NATS_VERSION_SUFFIX "")

set(NATS_VERSION_REQUIRED_NUMBER 0x030900)
set(NATS_VERSION_REQUIRED_NUMBER 0x030A00)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't recall that my original intent was to use hex numbers for major, minor, update, meaning it should probably be 0x031000. What matters is that the library is able to detect that the number from the header is greater/smaller or not than the one from the library.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kozlovic I think it's doing the right thing now (hex), see

static void
and https://github.com/nats-io/nats.c/blob/f356e634faf2bf4c37ce7d092dc056ff17e55784/test/test.c#L16604, or am I misinterpreting?

@levb levb Feb 28, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kozlovic also, if I set it to ...0310... the test fails

@levb
levb requested a review from kozlovic February 28, 2025 17:53

@kozlovic kozlovic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, my bad. LGTM!

@mtmk mtmk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@levb
levb merged commit 61c051f into release_3_10 Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants