Release v3.10 - #853
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release_3_10 #853 +/- ##
===============================================
Coverage ? 70.40%
===============================================
Files ? 47
Lines ? 15410
Branches ? 3161
===============================================
Hits ? 10849
Misses ? 1517
Partials ? 3044 ☔ View full report in Codecov by Sentry. |
|
Please see #852 for the docs changes that will be used for |
kozlovic
left a comment
There was a problem hiding this comment.
Could we check on the version required number?
| set(NATS_VERSION_SUFFIX "") | ||
|
|
||
| set(NATS_VERSION_REQUIRED_NUMBER 0x030900) | ||
| set(NATS_VERSION_REQUIRED_NUMBER 0x030A00) |
There was a problem hiding this comment.
I don't recall that my original intent was to use hex numbers for major, minor, update, meaning it should probably be 0x031000. What matters is that the library is able to detect that the number from the header is greater/smaller or not than the one from the library.
There was a problem hiding this comment.
@kozlovic I think it's doing the right thing now (hex), see
Line 170 in f356e63
There was a problem hiding this comment.
@kozlovic also, if I set it to ...0310... the test fails
Release notes:
Added
Fixed
NATS_EXTERNon some functions. by @kozlovic in [FIXED] Added missingNATS_EXTERNon some functions. #836Non-code changes
New Contributors
Full Changelog: v3.9.0...v3.10