Skip to content

Release v3.10 #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
levb merged 2 commits into from
Feb 28, 2025
Merged

Release v3.10 #853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a10076f
Updated version to v3.10
Feb 28, 2025
83a8684
Updated version references in README
Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,9 +261,9 @@ endif(NATS_BUILD_WITH_TLS)
set(NATS_VERSION_MAJOR 3)
set(NATS_VERSION_MINOR 10)
set(NATS_VERSION_PATCH 0)
set(NATS_VERSION_SUFFIX "-beta")
set(NATS_VERSION_SUFFIX "")

set(NATS_VERSION_REQUIRED_NUMBER 0x030900)
set(NATS_VERSION_REQUIRED_NUMBER 0x030A00)

@kozlovic kozlovic Feb 28, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't recall that my original intent was to use hex numbers for major, minor, update, meaning it should probably be 0x031000. What matters is that the library is able to detect that the number from the header is greater/smaller or not than the one from the library.

@levb levb Feb 28, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kozlovic I think it's doing the right thing now (hex), see

nats.c/src/nats.c

Line 170 in f356e63

static void
and https://github.com/nats-io/nats.c/blob/f356e634faf2bf4c37ce7d092dc056ff17e55784/test/test.c#L16604, or am I misinterpreting?

@levb levb Feb 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kozlovic also, if I set it to ...0310... the test fails


write_basic_package_version_file(
"${PROJECT_BINARY_DIR}/cnats-config-version.cmake"
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ This NATS Client implementation is heavily based on the [NATS GO Client](https:/
[![License Apache 2](https://img.shields.io/badge/License-Apache2-blue.svg)](https://www.apache.org/licenses/LICENSE-2.0)
[![Build Status](https://travis-ci.com/nats-io/nats.c.svg?branch=main)](https://travis-ci.com/github/nats-io/nats.c)
[![Coverage Status](https://coveralls.io/repos/github/nats-io/nats.c/badge.svg?branch=main)](https://coveralls.io/github/nats-io/nats.c?branch=main)
[![Release](https://img.shields.io/badge/release-v3.9.2-blue.svg?style=flat)](https://github.com/nats-io/nats.c/releases/tag/v3.9.2)
[![Release](https://img.shields.io/badge/release-v3.10.0-blue.svg?style=flat)](https://github.com/nats-io/nats.c/releases/tag/v3.10.0)
[![Documentation](https://img.shields.io/badge/doc-Doxygen-brightgreen.svg?style=flat)](http://nats-io.github.io/nats.c)

# Table of Contents
Expand Down
2 changes: 1 addition & 1 deletion doc/DoxyFile.NATS.Client
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ PROJECT_NAME = NATS C Client with JetStream and Streaming support
# could be handy for archiving the generated documentation or if some version
# control system is used.

PROJECT_NUMBER = 3.10.0-beta
PROJECT_NUMBER = 3.10.0

# Using the PROJECT_BRIEF tag one can provide an optional one line description
# for a project that appears at the top of each page and should give viewer a
Expand Down
4 changes: 2 additions & 2 deletions src/version.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,13 @@ extern "C" {
#define NATS_VERSION_MINOR 10
#define NATS_VERSION_PATCH 0

#define NATS_VERSION_STRING "3.10.0-beta"
#define NATS_VERSION_STRING "3.10.0"

#define NATS_VERSION_NUMBER ((NATS_VERSION_MAJOR << 16) | \
(NATS_VERSION_MINOR << 8) | \
NATS_VERSION_PATCH)

#define NATS_VERSION_REQUIRED_NUMBER 0x030900
#define NATS_VERSION_REQUIRED_NUMBER 0x030A00

#ifdef __cplusplus
}
Expand Down