Skip to content

[FIXED] build error (#819) - #820

Merged
levb merged 1 commit into
nats-io:mainfrom
oldnick85:add_stddef_header
Dec 3, 2024
Merged

[FIXED] build error (#819)#820
levb merged 1 commit into
nats-io:mainfrom
oldnick85:add_stddef_header

Conversation

@oldnick85

Copy link
Copy Markdown
Contributor

add stddef include to fix error build with NATS_BUILD_WITH_TLS=OFF NATS_BUILD_STREAMING=OFF NATS_BUILD_USE_SODIUM=OFF

add stddef include to fix error build with NATS_BUILD_WITH_TLS=OFF NATS_BUILD_STREAMING=OFF NATS_BUILD_USE_SODIUM=OFF

@kozlovic kozlovic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread src/glib/glib.c
// See the License for the specific language governing permissions and
// limitations under the License.

#include <stddef.h>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It got lost during PR #778. The change here looks good to me.

Since we need this header (so far) only because of "offsetof" that is only in this C file, it could simply be included here, but I will let @levb decide if he would rather have it in "glibp.h".

@levb levb left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@levb
levb merged commit f20f247 into nats-io:main Dec 3, 2024
levb pushed a commit to levb/nats.c that referenced this pull request Dec 9, 2024
add stddef include to fix error build with NATS_BUILD_WITH_TLS=OFF NATS_BUILD_STREAMING=OFF NATS_BUILD_USE_SODIUM=OFF

Co-authored-by: oldnick85 <nikitatapin0023@gmail.com>
@levb levb removed the cherry-pick label Dec 9, 2024
@levb

levb commented Dec 9, 2024

Copy link
Copy Markdown
Collaborator

Cherry-picked into v3.9.2

@oldnick85
oldnick85 deleted the add_stddef_header branch December 9, 2024 17:39
@levb levb mentioned this pull request Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants