Skip to content

Add support for illumos#7122

Merged
neilalexander merged 1 commit intonats-io:mainfrom
jwntree:illumos
Aug 11, 2025
Merged

Add support for illumos#7122
neilalexander merged 1 commit intonats-io:mainfrom
jwntree:illumos

Conversation

@jwntree
Copy link
Copy Markdown
Contributor

@jwntree jwntree commented Jul 30, 2025

This allow NATS Server to build under the illumos.

Signed-off-by: Jiwon Na jwntree@hotmail.com

@jwntree jwntree requested a review from a team as a code owner July 30, 2025 16:50
@neilalexander
Copy link
Copy Markdown
Member

Indeed nice that this PR reports more thoroughly, any chance you can rebase on latest main & address the sign-off in the commit message too?

@jperkin
Copy link
Copy Markdown

jperkin commented Aug 7, 2025

Yeh this approach is better, however it does not currently support the illumos build tag. Please can you add it so that this change supports illumos as well as Solaris. Thanks.

@jwntree jwntree force-pushed the illumos branch 2 times, most recently from 20788a7 to 136ec3c Compare August 10, 2025 13:22
Signed-off-by: Jiwon Na <jwntree@hotmail.com>
Copy link
Copy Markdown
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@neilalexander neilalexander merged commit 833cc2a into nats-io:main Aug 11, 2025
86 of 89 checks passed
neilalexander added a commit that referenced this pull request Aug 13, 2025
Includes the following:

- #7140
- #7142
- #7145
- #7150
- #7151
- #7154
- #7156
- #7122
- #7166 (excluding the Go
version bump)
- #7162
- #7165

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants