Skip to content

[FIXED] Loading block error when recovering TTL#7150

Merged
neilalexander merged 1 commit intomainfrom
maurice/fs-ttl-recover-log
Aug 7, 2025
Merged

[FIXED] Loading block error when recovering TTL#7150
neilalexander merged 1 commit intomainfrom
maurice/fs-ttl-recover-log

Conversation

@MauriceVanVeen
Copy link
Copy Markdown
Member

Filestore could log Error loading msg block with seq 100 for recovering TTL: %!s(MISSING). This PR fixes the missing param in the log line, as well as breaking the loop instead of goto retry if we've already gone through the last block.

Signed-off-by: Maurice van Veen github@mauricevanveen.com

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
@MauriceVanVeen MauriceVanVeen requested a review from a team as a code owner August 6, 2025 10:09
Copy link
Copy Markdown
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander neilalexander merged commit 64c29e6 into main Aug 7, 2025
153 of 158 checks passed
@neilalexander neilalexander deleted the maurice/fs-ttl-recover-log branch August 7, 2025 08:51
neilalexander added a commit that referenced this pull request Aug 13, 2025
Includes the following:

- #7140
- #7142
- #7145
- #7150
- #7151
- #7154
- #7156
- #7122
- #7166 (excluding the Go
version bump)
- #7162
- #7165

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants