Closed
Conversation
Member
|
Principally happy with this but the CI is red because the commit message doesn't include the sign-off too. Any chance you can rebase & fix the commit message? |
Signed-off-by: Jonathan Perkin <jonathan@perkin.org.uk>
Author
|
Sorry, yes! I missed that the first time. Pushed. |
Contributor
|
Sorry to interrupt, but wouldn’t this be a better approach? Also, I can't understand why you should handle irrelevant zos codes... |
Author
|
Happy for this to be closed in lieu of #7122 once that PR supports illumos. Thanks! |
Member
|
Have merged #7122, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the build on illumos (and probably Solaris). While this may be useful for nats-server itself, this is more for other software such as telegraf that depends on this and which is currently unbuildable on illumos due to this problem. Whether you have any interest in supporting these platforms natively, we'd really appreciate this or a similar patch be applied so that other software is not adversely affected.
Previous iterations of this patch supported
sysmembut used cgo (jperkin@7d43c51), so this newer version simply uses the unsupported routine the same as wasm/zos (which is now combined into a single file).Many thanks.
Signed-off-by: Jonathan Perkin jonathan@perkin.org.uk