Skip to content

Add logging for large metalayer snapshots duration#6178

Merged
derekcollison merged 2 commits intomainfrom
meta-snapshot-took
Nov 26, 2024
Merged

Add logging for large metalayer snapshots duration#6178
derekcollison merged 2 commits intomainfrom
meta-snapshot-took

Conversation

@wallyqs
Copy link
Copy Markdown
Member

@wallyqs wallyqs commented Nov 26, 2024

This adds extra WRN level logging to detect cases when there is a slowness in the metalayer snapshot duration, example line:

[WRN] Metalayer snapshot took 1.113s (streams: 326, consumers: 29382, marshal: 1.103s, uncompressed: 33268722, compressed: 2768064)

Signed-off-by: Waldemar Quevedo <wally@nats.io>
@wallyqs wallyqs requested a review from a team as a code owner November 26, 2024 15:02
Signed-off-by: Neil Twigg <neil@nats.io>
Copy link
Copy Markdown
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 8b3bb06 into main Nov 26, 2024
@derekcollison derekcollison deleted the meta-snapshot-took branch November 26, 2024 17:10
neilalexander added a commit that referenced this pull request Nov 26, 2024
Includes the following:

- #6169
- #6165
- #6173
- #6175
- #6176
- #6178

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants