[IMPROVED] Encoding for large meta snapshots#6165
Merged
derekcollison merged 3 commits intomainfrom Nov 25, 2024
Merged
Conversation
…lize s2.Encode vs EncodeBetter wich is faster and compresses better on our meta snapshots. Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
Member
Author
|
FYI plan to add test to remove us snapshotting so much on consumer deletes as well here so feel free to hold off, but looks very promising and sans the one test that I had to fix passed the first time all others. |
…onsumer removals to avoind excesive snapshotting. Signed-off-by: Derek Collison <derek@nats.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve very large meta snapshots by moving to goccy json pkg and utilize s2.Encode vs EncodeBetter which is faster and compresses better on on our meta snapshots.
Signed-off-by: Derek Collison derek@nats.io