Skip to content

fix(leafnode): credentials parsing for leafnode connections doesn't handle CRLFs correctly#6175

Merged
derekcollison merged 2 commits intomainfrom
fix-6167
Nov 26, 2024
Merged

fix(leafnode): credentials parsing for leafnode connections doesn't handle CRLFs correctly#6175
derekcollison merged 2 commits intomainfrom
fix-6167

Conversation

@aricart
Copy link
Copy Markdown
Member

@aricart aricart commented Nov 25, 2024

Leaf node credential parsing was using a regular expression that didn't handle CRLFs correctly

Fix #6167

Signed-off-by: Your Name alberto@synadia.com

…andle CRLFs correctly.

Fix #6167

Signed-off-by: Alberto Ricart <alberto@synadia.com>
@aricart aricart requested a review from a team as a code owner November 25, 2024 21:23
@derekcollison
Copy link
Copy Markdown
Member

Please fix.

image

Signed-off-by: Alberto Ricart <alberto@synadia.com>
Copy link
Copy Markdown
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit fa50c75 into main Nov 26, 2024
@derekcollison derekcollison deleted the fix-6167 branch November 26, 2024 01:03
neilalexander pushed a commit that referenced this pull request Nov 26, 2024
…andle CRLFs correctly (#6175)

Leaf node credential parsing was using a regular expression that didn't
handle CRLFs correctly

Fix #6167

Signed-off-by: Your Name <alberto@synadia.com>

---------

Signed-off-by: Alberto Ricart <alberto@synadia.com>
neilalexander pushed a commit that referenced this pull request Nov 26, 2024
…andle CRLFs correctly (#6175)

Leaf node credential parsing was using a regular expression that didn't
handle CRLFs correctly

Fix #6167

Signed-off-by: Your Name <alberto@synadia.com>

---------

Signed-off-by: Alberto Ricart <alberto@synadia.com>
neilalexander pushed a commit that referenced this pull request Nov 26, 2024
…andle CRLFs correctly (#6175)

Leaf node credential parsing was using a regular expression that didn't
handle CRLFs correctly

Fix #6167

Signed-off-by: Your Name <alberto@synadia.com>

---------

Signed-off-by: Alberto Ricart <alberto@synadia.com>
neilalexander added a commit that referenced this pull request Nov 26, 2024
Includes the following:

- #6169
- #6165
- #6173
- #6175
- #6176
- #6178

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Leaf Node Credentials File regex dies on CRLF file endings

2 participants