Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #152, Correct typos in documentation, print statements, and comments #151

Merged
merged 2 commits into from
Sep 10, 2021
Merged

Fix #152, Correct typos in documentation, print statements, and comments #151

merged 2 commits into from
Sep 10, 2021

Conversation

thnkslprpt
Copy link
Contributor

@thnkslprpt thnkslprpt commented Aug 21, 2021 •
edited by astrogeco
Loading

Describe the contribution

Fixed a few minor typos in the text of:

  • README.md
  • SECURITY.md

...and in the comments of:

  • unit-test/CMakeLists.txt

...and in an assert error message string of:

  • unit-test/coveragetest/coveragetest_sample_app.c

Testing performed
Only automated checks.

Expected behavior changes
None (minor Markdown doc, comments changes, and assert error string changes that do not interact with any max lengths etc.).

System(s) tested on
n/a

Additional context
n/a

Code contributions
n/a

@thnkslprpt thnkslprpt marked this pull request as draft September 1, 2021 14:11
@thnkslprpt thnkslprpt marked this pull request as ready for review September 1, 2021 15:24
astrogeco added a commit to nasa/cFS that referenced this pull request Sep 10, 2021
@astrogeco
nasa/osal#1137
7bd5a02 
nasa/PSP#300

nasa/ci_lab#89
nasa/sample_app#151
nasa/sch_lab#84
nasa/to_lab#101
nasa/sample_lib#65
nasa/elf2cfetbl#82
nasa/tblCRCTool#53
@astrogeco astrogeco mentioned this pull request Sep 10, 2021
Merged
2 tasks
@astrogeco astrogeco merged commit a03e113 into nasa:main Sep 10, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request Sep 10, 2021
@astrogeco @thnkslprpt
IC:2021-09-10, Documentation Updates
51e0b52 
**Combines**

nasa/cFE#1915
nasa/osal#1137
nasa/PSP#300

nasa/ci_lab#89
nasa/sample_app#151
nasa/sch_lab#84
nasa/to_lab#101
nasa/sample_lib#65
nasa/elf2cfetbl#82
nasa/tblCRCTool#53

Co-authored-by: Avi <[email protected]>
@astrogeco astrogeco mentioned this pull request Sep 11, 2021
Closed
@astrogeco astrogeco changed the title Fixed typos in readme docs and test error message Fix #152, Correct typos in documentation, print statements, and comments Sep 11, 2021
astrogeco added a commit to astrogeco/sample_app that referenced this pull request Sep 11, 2021
@astrogeco
Merge pull request nasa#151 from thnkslprpt/FIX-SAMPLE-APP-TYPOS
847ba8e 
Fix nasa#152, Correct typos in documentation, print statements, and comments

Part of nasa/cFS#352
astrogeco added a commit to nasa/cFS that referenced this pull request Sep 11, 2021
@astrogeco @thnkslprpt
IC:2021-09-10, Fix Typos in docs and source
ece6e21 
**Combines**

nasa/cFE#1915
nasa/osal#1137
nasa/PSP#300

nasa/ci_lab#89
nasa/sample_app#151
nasa/sch_lab#84
nasa/to_lab#101
nasa/sample_lib#65
nasa/elf2cfetbl#82
nasa/tblCRCTool#53

Co-authored-by: Avi <[email protected]>
@astrogeco
Copy link
Contributor

Tested in astrogeco@847ba8e

Merged in 847ba8e

astrogeco added a commit to nasa/cFS that referenced this pull request Sep 11, 2021
@astrogeco @thnkslprpt
IC:2021-09-10, Fix Typos in docs and comments
d697bda 
**Combines**

nasa/cFE#1915
nasa/osal#1137
nasa/PSP#300

nasa/ci_lab#89
nasa/sample_app#151
nasa/sch_lab#84
nasa/to_lab#101
nasa/sample_lib#65
nasa/elf2cfetbl#82
nasa/tblCRCTool#53

Co-authored-by: Avi <[email protected]>
astrogeco added a commit to nasa/cFS that referenced this pull request Sep 11, 2021
@astrogeco @thnkslprpt
IC:2021-09-10, Fix Typos in docs and code
0067b76 
**Combines**

nasa/cFE#1915
nasa/osal#1137
nasa/PSP#300

nasa/ci_lab#89
nasa/sample_app#151
nasa/sch_lab#84
nasa/to_lab#101
nasa/sample_lib#65
nasa/elf2cfetbl#82
nasa/tblCRCTool#53

Co-authored-by: Avi <[email protected]>
@thnkslprpt thnkslprpt deleted the FIX-SAMPLE-APP-TYPOS branch September 11, 2021 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArielSAdamsNASA ArielSAdamsNASA ArielSAdamsNASA approved these changes

Assignees

@ArielSAdamsNASA ArielSAdamsNASA

Labels
community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typos in documentation, print statements, and comments
3 participants
@thnkslprpt @astrogeco @ArielSAdamsNASA