Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1946, Correct various typos in docs, comments and error messages #1915

Merged
merged 4 commits into from
Sep 10, 2021
Merged

Fix #1946, Correct various typos in docs, comments and error messages #1915

merged 4 commits into from
Sep 10, 2021

Conversation

thnkslprpt
Copy link
Contributor

@thnkslprpt thnkslprpt commented Aug 30, 2021 •
edited by astrogeco
Loading

Describe the contribution
Fixed various minor typos in README docs, comments and a few debug/error/description message strings.

Testing performed
None (non-executable code).

Expected behavior changes
None. Code execution is unchanged/unaffected.

System(s) tested on
n/a

Additional context
n/a

Code contributions
n/a

@thnkslprpt thnkslprpt marked this pull request as draft September 1, 2021 14:23
@thnkslprpt thnkslprpt marked this pull request as ready for review September 1, 2021 16:32
@astrogeco astrogeco added the community Community contribution, YAY! label Sep 1, 2021
ArielSAdamsNASA
ArielSAdamsNASA reviewed Sep 9, 2021
View reviewed changes
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md
@@ -359,7 +359,7 @@ Updates the doxygen documentation for this parameter, as it was incorrectly spec

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get rid of extra space on line 355, between the words on and inclusion in Adds documentation on inclusion presence of null terminators for length parameters..

README.md Show resolved Hide resolved
docs/cFE Application Developers Guide.md Show resolved Hide resolved
docs/cFE Application Developers Guide.md Show resolved Hide resolved
astrogeco added a commit to nasa/cFS that referenced this pull request Sep 10, 2021
@astrogeco
nasa/cFE#1915
5797647
@astrogeco astrogeco mentioned this pull request Sep 10, 2021
Merged
2 tasks
astrogeco added a commit to nasa/cFS that referenced this pull request Sep 10, 2021
@astrogeco
fix merge conflict for nasa/cFE#1915
50b0d61
@astrogeco
Copy link
Contributor

astrogeco commented Sep 10, 2021 •
edited
Loading

Merge conflicts resolved and tested in astrogeco@64a6a59

Merged in 64a6a59

@astrogeco astrogeco merged commit 74d5c28 into nasa:main Sep 10, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request Sep 10, 2021
@astrogeco @thnkslprpt
IC:2021-09-10, Documentation Updates
51e0b52 
**Combines**

nasa/cFE#1915
nasa/osal#1137
nasa/PSP#300

nasa/ci_lab#89
nasa/sample_app#151
nasa/sch_lab#84
nasa/to_lab#101
nasa/sample_lib#65
nasa/elf2cfetbl#82
nasa/tblCRCTool#53

Co-authored-by: Avi <[email protected]>
@astrogeco astrogeco mentioned this pull request Sep 11, 2021
Closed
astrogeco pushed a commit to astrogeco/cFE that referenced this pull request Sep 11, 2021
@thnkslprpt @astrogeco
Fix nasa#1915, Correct documentation typos
8d4511b 
Also fix typos in EDS XML docs
astrogeco added a commit to astrogeco/cFE that referenced this pull request Sep 11, 2021
@astrogeco
Merge pull request nasa#1915 from thnkslprpt/FIX-CFE-TYPOS
64a6a59 
Fix nasa#1946, Correct typos in docs, comments and error messages.

Part of nasa/cFS#352
@astrogeco astrogeco changed the title Fixed various typos in docs, comments and error messages. Fix #1946, Correct various typos in docs, comments and error messages. Sep 11, 2021
@astrogeco astrogeco changed the title Fix #1946, Correct various typos in docs, comments and error messages. Fix #1946, Correct various typos in docs, comments and error messages Sep 11, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request Sep 11, 2021
@astrogeco @thnkslprpt
IC:2021-09-10, Fix Typos in docs and source
ece6e21 
**Combines**

nasa/cFE#1915
nasa/osal#1137
nasa/PSP#300

nasa/ci_lab#89
nasa/sample_app#151
nasa/sch_lab#84
nasa/to_lab#101
nasa/sample_lib#65
nasa/elf2cfetbl#82
nasa/tblCRCTool#53

Co-authored-by: Avi <[email protected]>
astrogeco added a commit to nasa/cFS that referenced this pull request Sep 11, 2021
@astrogeco @thnkslprpt
IC:2021-09-10, Fix Typos in docs and comments
d697bda 
**Combines**

nasa/cFE#1915
nasa/osal#1137
nasa/PSP#300

nasa/ci_lab#89
nasa/sample_app#151
nasa/sch_lab#84
nasa/to_lab#101
nasa/sample_lib#65
nasa/elf2cfetbl#82
nasa/tblCRCTool#53

Co-authored-by: Avi <[email protected]>
astrogeco added a commit to nasa/cFS that referenced this pull request Sep 11, 2021
@astrogeco @thnkslprpt
IC:2021-09-10, Fix Typos in docs and code
0067b76 
**Combines**

nasa/cFE#1915
nasa/osal#1137
nasa/PSP#300

nasa/ci_lab#89
nasa/sample_app#151
nasa/sch_lab#84
nasa/to_lab#101
nasa/sample_lib#65
nasa/elf2cfetbl#82
nasa/tblCRCTool#53

Co-authored-by: Avi <[email protected]>
@thnkslprpt thnkslprpt deleted the FIX-CFE-TYPOS branch September 11, 2021 07:28
@skliper skliper added this to the 7.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArielSAdamsNASA ArielSAdamsNASA ArielSAdamsNASA left review comments

Assignees

@ArielSAdamsNASA ArielSAdamsNASA

Labels
community Community contribution, YAY!
Projects
None yet
Milestone
Caelum
Development

Successfully merging this pull request may close these issues.

Typos in documentation, print statements, and comments
4 participants
@thnkslprpt @astrogeco @ArielSAdamsNASA @skliper