Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #84, Correct comment and event message typos #82

Merged
merged 2 commits into from
Sep 10, 2021
Merged

Fix #84, Correct comment and event message typos #82

merged 2 commits into from
Sep 10, 2021

Conversation

thnkslprpt
Copy link
Contributor

@thnkslprpt thnkslprpt commented Aug 21, 2021 •
edited by astrogeco
Loading

Describe the contribution
Fixed various minor text typos in comments and event message strings.

Testing performed
Only automated checks.

Expected behavior changes
None (minor comments and event message strings that do not interact with any max lengths etc.). Code execution is unaffected.

System(s) tested on
n/a

Additional context
n/a

Code contributions
n/a

@thnkslprpt thnkslprpt force-pushed the FIX-ELF2CFETBL-TYPOS branch from 90589bb to e4c73ea Compare August 21, 2021 19:00
@thnkslprpt thnkslprpt marked this pull request as draft September 1, 2021 14:22
@thnkslprpt thnkslprpt marked this pull request as ready for review September 1, 2021 15:11
astrogeco added a commit to nasa/cFS that referenced this pull request Sep 10, 2021
@astrogeco
nasa/osal#1137
7bd5a02 
nasa/PSP#300

nasa/ci_lab#89
nasa/sample_app#151
nasa/sch_lab#84
nasa/to_lab#101
nasa/sample_lib#65
nasa/elf2cfetbl#82
nasa/tblCRCTool#53
@astrogeco astrogeco mentioned this pull request Sep 10, 2021
Merged
2 tasks
astrogeco added a commit to astrogeco/elf2cfetbl that referenced this pull request Sep 10, 2021
@astrogeco
Merge pull request nasa#82 from thnkslprpt/FIX-ELF2CFETBL-TYPOS
5bb1d55 
Fixed comment and event message typos

Part of nasa/cFS#352
@astrogeco
Copy link
Contributor

astrogeco commented Sep 10, 2021 •
edited
Loading

Tested at https://github.com/astrogeco/elf2cfetbl/tree/thnkslprpt/FIX-ELF2CFETBL-TYPOS, and nasa/cFS#352. Made minor edits to ensure format check passes

Merged in 10f55fb

astrogeco added a commit to astrogeco/elf2cfetbl that referenced this pull request Sep 10, 2021
@astrogeco
Merge pull request nasa#82 from thnkslprpt/FIX-ELF2CFETBL-TYPOS
969b3d5 
Fixed comment and event message typos

Part of nasa/cFS#352
astrogeco added a commit to nasa/cFS that referenced this pull request Sep 10, 2021
@astrogeco
Test merge of nasa/elf2cfetbl#82
3e86673
@astrogeco astrogeco merged commit 6f54f14 into nasa:main Sep 10, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request Sep 10, 2021
@astrogeco @thnkslprpt
IC:2021-09-10, Documentation Updates
51e0b52 
**Combines**

nasa/cFE#1915
nasa/osal#1137
nasa/PSP#300

nasa/ci_lab#89
nasa/sample_app#151
nasa/sch_lab#84
nasa/to_lab#101
nasa/sample_lib#65
nasa/elf2cfetbl#82
nasa/tblCRCTool#53

Co-authored-by: Avi <[email protected]>
@astrogeco astrogeco mentioned this pull request Sep 11, 2021
Closed
@astrogeco astrogeco changed the title Fixed comment and event message typos. Fix #84, Correct comment and event message typos Sep 11, 2021
astrogeco added a commit to astrogeco/elf2cfetbl that referenced this pull request Sep 11, 2021
@astrogeco
Merge pull request nasa#82 from thnkslprpt/FIX-ELF2CFETBL-TYPOS
d56b0b9 
Fix nasa#84, Correct comment and event message typos.

Part of nasa/cFS#352
astrogeco added a commit to nasa/cFS that referenced this pull request Sep 11, 2021
@astrogeco @thnkslprpt
IC:2021-09-10, Fix Typos in docs and source
ece6e21 
**Combines**

nasa/cFE#1915
nasa/osal#1137
nasa/PSP#300

nasa/ci_lab#89
nasa/sample_app#151
nasa/sch_lab#84
nasa/to_lab#101
nasa/sample_lib#65
nasa/elf2cfetbl#82
nasa/tblCRCTool#53

Co-authored-by: Avi <[email protected]>
astrogeco added a commit to astrogeco/elf2cfetbl that referenced this pull request Sep 11, 2021
@astrogeco
Merge pull request nasa#82 from thnkslprpt/FIX-ELF2CFETBL-TYPOS
10f55fb 
Fix nasa#84, Correct comment and event message typos.

Part of nasa/cFS#352
astrogeco added a commit to nasa/cFS that referenced this pull request Sep 11, 2021
@astrogeco @thnkslprpt
IC:2021-09-10, Fix Typos in docs and comments
d697bda 
**Combines**

nasa/cFE#1915
nasa/osal#1137
nasa/PSP#300

nasa/ci_lab#89
nasa/sample_app#151
nasa/sch_lab#84
nasa/to_lab#101
nasa/sample_lib#65
nasa/elf2cfetbl#82
nasa/tblCRCTool#53

Co-authored-by: Avi <[email protected]>
astrogeco added a commit to nasa/cFS that referenced this pull request Sep 11, 2021
@astrogeco @thnkslprpt
IC:2021-09-10, Fix Typos in docs and code
0067b76 
**Combines**

nasa/cFE#1915
nasa/osal#1137
nasa/PSP#300

nasa/ci_lab#89
nasa/sample_app#151
nasa/sch_lab#84
nasa/to_lab#101
nasa/sample_lib#65
nasa/elf2cfetbl#82
nasa/tblCRCTool#53

Co-authored-by: Avi <[email protected]>
@thnkslprpt thnkslprpt deleted the FIX-ELF2CFETBL-TYPOS branch September 11, 2021 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArielSAdamsNASA ArielSAdamsNASA ArielSAdamsNASA approved these changes

Assignees

@ArielSAdamsNASA ArielSAdamsNASA

Labels
community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typos in documentation, print statements, and comments
3 participants
@thnkslprpt @astrogeco @ArielSAdamsNASA