Fix #887, specify shell name in ShellOutputToFile #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than using a default name, use a specific name so that it can be polled more safely.
jphickey
added
the
CCB:Ready
|
Submitted issue #939 about related shell issue discovered when attempting to test this. |
|
Also worth noting - this assumes that VxWorks will honor and use the shell name specified. Technically the VxWorks documentation for |
|
CCB 2021-03-31 APPROVED |
astrogeco
added
CCB:Approved
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Apr 8, 2021
nasa/osal#931 - Scrub include guards nasa/osal#937 - Switch to use CLOCK_REALTIME nasa/osal#938 - Specify shell name in ShellOutputToFile
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Apr 8, 2021
Combines: nasa/cFE#1284 nasa/osal#951 nasa/PSP#289 Including: nasa/cFE#1251 - ES Info API Functional test nasa/osal#931 - Scrub include guards nasa/osal#937 - Switch to use CLOCK_REALTIME nasa/osal#938 - specify shell name in ShellOutputToFile nasa/PSP#286 - use OSAL timebase for CFE timers nasa/PSP#282 - modularize the ram, port, and eenasa/psp#om access nasa/PSP#285 - add psp module to implement timebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Rather than using a default name, use a specific name so that it can be polled more safely.
Fixes #887
Testing performed
Build and run coverage tests
Also enable shell and run "shell-test" on MCP750
Expected behavior changes
No longer using a string pointer which may be invalid.
System(s) tested on
MCP750, vxworks 6.9
Additional context
Although this while loop seems to be working OK, the overall "shell-test" actually fails on the MCP750 because it looks like the shell does not have an "echo" function. This seems to be a separate issue, not sure if/how this test ever worked.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.