Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS_ShellOutputToFile_Impl in VxWorks is not thread safe #887

Closed
skliper opened this issue Mar 11, 2021 · 0 comments · Fixed by #938 or #951
Closed

OS_ShellOutputToFile_Impl in VxWorks is not thread safe #887

skliper opened this issue Mar 11, 2021 · 0 comments · Fixed by #938 or #951
Assignees
Milestone

Comments

@skliper
Copy link
Contributor

skliper commented Mar 11, 2021

Is your feature request related to a problem? Please describe.
Filename is common:

} while (taskNameToId(shellName) != ((TASK_ID)ERROR));

Describe the solution you'd like
At minimum document. Consider refactor for shell safe implementation. Although current cFS concept is to use a single app and even this should be avoided when possible (direct shell use is discouraged in production ops).

Describe alternatives you've considered
Deprecate/remove.

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC, OSAL code review

@skliper skliper added this to the 6.0.0 milestone Mar 11, 2021
jphickey added a commit to jphickey/osal that referenced this issue Mar 31, 2021
Rather than using a default name, use a specific name so that
it can be polled more safely.
jphickey added a commit to jphickey/osal that referenced this issue Mar 31, 2021
jphickey added a commit to jphickey/osal that referenced this issue Mar 31, 2021
Rather than using a default name, use a specific name so that
it can be polled more safely.
astrogeco added a commit that referenced this issue Apr 8, 2021
Fix #887, specify shell name in ShellOutputToFile
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants