Fix #171, use OSAL timebase for CFE timers #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new PSP module that instantiates an OSAL abstract timebase for use with cFE services. This single module is then used across all 3 implementations (mcp750, pc-linux, pc-rtems) and does not need to be duplicated.
jphickey
force-pushed
the
fix-171-osal-timebase
branch
from
bc4649a to
bfbd1b2
Compare
|
The build failure here is because it depends on a fix currently in #282. Once merged together it builds fine. |
jphickey
added
the
CCB:Ready
|
CCB:2021-03-31 APPROVED
|
astrogeco
removed
the
CCB:Ready
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Apr 6, 2021
astrogeco
added a commit
that referenced
this pull request
Apr 7, 2021
Re-add timebase name definition `CFE_PSP_SOFT_TIMEBASE_NAME` to `cfe_psp.h`
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Apr 8, 2021
Combines: nasa/cFE#1284 nasa/osal#951 nasa/PSP#289 Including: nasa/cFE#1251 - ES Info API Functional test nasa/osal#931 - Scrub include guards nasa/osal#937 - Switch to use CLOCK_REALTIME nasa/osal#938 - specify shell name in ShellOutputToFile nasa/PSP#286 - use OSAL timebase for CFE timers nasa/PSP#282 - modularize the ram, port, and eenasa/psp#om access nasa/PSP#285 - add psp module to implement timebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Add a new PSP module that instantiates an OSAL abstract timebase for use with cFE services. This single module is then used
across all 3 implementations (mcp750, pc-linux, pc-rtems) and does not need to be duplicated.
Cleans up stale code from the previous method(s) of generating 1Hz
Fixes #171
Testing performed
Build and sanity check CFE, run all unit tests
Make sure 1Hz timing ticks are working as expected
Expected behavior changes
1Hz timing tick on MCP750 will be more accurate
No changes to Linux/RTEMS
System(s) tested on
MCP750 vxworks 6.9
Ubuntu 20.04
RTEMS 4.11.3 (qemu)
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.