osal Integration candidate: 2021-05-18 #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CCB 2021-05-05 review item. Makes filenames better match terms used in implementation.
The status code from the low level implementation needs to be returned from the caller, in case it was not OS_SUCCESS.
Update most of the conditions in the "unit tests" to use the support macros whenever possible. The macros display the function being called as well as the return value being checked for, and therefore this makes it so the test log file can be cross referenced back to the documentation to ensure the documented return codes are being tested. As a nice side effect this also removes quite a bit of repetition in the test programs.
If messages (e.g. from UtPrintf, etc) already have a newline, do not add another.
Fix #983, rename hooks to handlers
Fix #999, propagate status code in OS_rmdir
Fix #1002, remove extra newlines in utassert logs
Fix #981, rework "unit-tests" to use macros
This cuts the number of logged test cases from nearly 80k to about 580.
Fix #982, Add test for object id inline functions
Fix #994, fixed invalid inputs for OS_mkdir
Fix #986, Show CodeQL Preview
Update Readme and version.h
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
May 19, 2021
Combines: nasa/cFE#1508, cFE v6.8.0-rc1+dev580 nasa/osal#1006, osal v5.1.0-rc1+dev452 Includes: nasa/cFE#1482, Resolve sequence count auto-increment rollover bug nasa/cFE#1491, Correctly format code block section terminator nasa/cFE#1530, Fix typos in developer guide nasa/osal#985, rename hooks to handlers nasa/osal#1000, propagate status code in OS_rmdir nasa/osal#1001, rework "unit-tests" to use macros nasa/osal#1003, remove extra newlines in utassert logs nasa/osal#990, Add test for object id inline functions nasa/osal#998, fixed invalid inputs for OS_mkdir nasa/osal#812, Improves config guide documentation nasa/osal#987, Show CodeQL Preview
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
May 19, 2021
Combines: nasa/cFE#1508, cFE v6.8.0-rc1+dev580 nasa/osal#1006, osal v5.1.0-rc1+dev452 Includes: nasa/cFE#1482, Resolve sequence count auto-increment rollover bug nasa/cFE#1491, Correctly format code block section terminator nasa/cFE#1530, Fix typos in developer guide nasa/osal#985, rename hooks to handlers nasa/osal#1000, propagate status code in OS_rmdir nasa/osal#1001, rework "unit-tests" to use macros nasa/osal#1003, remove extra newlines in utassert logs nasa/osal#990, Add test for object id inline functions nasa/osal#998, fixed invalid inputs for OS_mkdir nasa/osal#812, Improves config guide documentation nasa/osal#987, Show CodeQL Preview Co-Authored-By: Jake Hageman <[email protected]> Co-Authored-By: Joseph Hickey <[email protected]> Co-Authored-By: Ariel Adams <[email protected]> Co-Authored-By: Alex Campbell <[email protected]> Co-Authored-By: Tobias Nießen <[email protected]> Co-Authored-By: Jonathan Bohren <[email protected]> Co-Authored-By: Andrei Tumbar <[email protected]>
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
…asa#1007) Co-authored-by: Gerardo E. Cruz-Ortiz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Part of nasa/cFS#259
Testing
osal checks https://github.com/nasa/osal/pull/1006/checks
cFS Bundle Checks https://github.com/nasa/cFS/pull/259/checks
Description
PR #985
Fix #983, rename hooks to handlers
CCB 2021-05-05 review item. Makes filenames better match terms used in implementation.
PR #1000
Fix #999, propagate status code in OS_rmdir
The status code from the low level implementation needs to be returned from the caller, in case it was not OS_SUCCESS.
The status returned from OS_rmdir() should now be correct if the implementation failed.
PR #1001
Fix #981, rework "unit-tests" to use macros
Adds details to log file and can be cross referenced back to documentation. Updates most of the conditions in the "unit tests" to use the support macros whenever possible. The macros display the function being called as well as the return value being checked for and enables that documented return codes are being tested. Removes repetition in the test programs.
PR #1003
Fix #1002, remove extra newlines in utassert logs
If messages (e.g. from UtPrintf, etc) already have a newline, do not add another.
Extra blank lines in test log are removed.
This should preserve extra newlines in the event that the test case was intentionally adding whitespace, by only appending one if it was not there to begin with.
PR #990
Fix #982, Add test for object id inline functions
OS_ObjectIdToInteger,OS_ObjectIdFromInteger,OS_ObjectIdEqual,OS_ObjectIdDefinednow have tests.PR #998,
Fix #994, fixed invalid inputs for OS_mkdir
Changed tests to use valid inputs for all OS_mkdir calls.
PR #812 - Community Contribution!
Improves config guide documentation issues referenced in #384, #640, #672
PR #987
Fix #986, Show CodeQL Preview
Authors
@ArielSAdamsNASA
@jphickey
@Kronos3
@zanzaben