-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove test run from CodeQL workflow #1007
Comments
If you remove it from here it needs to be added in somewhere else or as a new workflow. It was easy here since everything was built already. Could be done parallel. |
Aren't they running in https://github.com/nasa/osal/runs/2569594615?check_suite_focus=true ? |
Your reference is just the local unit tests for OSAL, the run referenced in this issue is the entire suite of cFS unit tests (with the cFS configuration). |
Note the full run will likely fail when there are dependencies, which I think is a GOOD thing (catches when we've missed something, notifies as part of the merge process that extra care is needed). As long as the PR justifies why it fails that's fine by me. |
ah! the output looked similar so I thought they were the same. Still think they should live in separate workflows but I do get the point of using the existing build to avoid duplicating the build step. I edited the original text and added an alternative resolution |
…asa#1007) Co-authored-by: Gerardo E. Cruz-Ortiz <[email protected]>
Describe the bug
CodeQL workflow is running unit tests which is confusing.
To Reproduce
See https://github.com/nasa/osal/actions/runs/835716057
Expected behavior
Code QL workflow should only run enough of the build steps to run the CodeQL analysis
Alternative
Keep the tests here, rename the workflow, and run the tests and codeql as separate jobs for parallelization
Code snips
osal/.github/workflows/codeql-build.yml
Lines 49 to 50 in 9756b03
System observed on:
github actions
Additional context
Ensure that new CodeQL workflow in #986 doesn't have the "run tests" step
The text was updated successfully, but these errors were encountered: