Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS_mkdir tests should use valid access settings (even though not implemented yet) #994

Closed
skliper opened this issue May 10, 2021 · 0 comments · Fixed by #998 or #1006
Closed

OS_mkdir tests should use valid access settings (even though not implemented yet) #994

skliper opened this issue May 10, 2021 · 0 comments · Fixed by #998 or #1006
Assignees
Labels
unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Milestone

Comments

@skliper
Copy link
Contributor

skliper commented May 10, 2021

Is your feature request related to a problem? Please describe.
Per note in the API:

osal/src/os/inc/osapi-dir.h

Lines 109 to 111 in 706f0de

* @note Current implementations do not utilize the "access" parameter. Applications
* should still pass the intended value (#OS_READ_WRITE or #OS_READ_ONLY) to be compatible
* with future implementations.

Yet tests don't use sensible values (examples):

status = OS_mkdir(dir1, 0);

if (OS_mkdir(g_dirName, 755) != OS_SUCCESS)

Describe the solution you'd like
Use appropriate values. 755 is definitely not correct and could lead to confusion.

Describe alternatives you've considered
At minimum don't use an incorrect value. 0 is probably least-bad...

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC

@skliper skliper added the unit-test Tickets related to the OSAL unit testing (functional and/or coverage) label May 10, 2021
@zanzaben zanzaben self-assigned this May 11, 2021
zanzaben added a commit to zanzaben/osal that referenced this issue May 11, 2021
zanzaben added a commit to zanzaben/osal that referenced this issue May 18, 2021
astrogeco added a commit that referenced this issue May 18, 2021
Fix #994, fixed invalid inputs for OS_mkdir
pepepr08 pushed a commit to pepepr08/osal that referenced this issue Jun 9, 2021
@skliper skliper added this to the 6.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Projects
None yet
2 participants