Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return error on moduleInfoGet error in VxWorks #886

Closed
skliper opened this issue Mar 11, 2021 · 0 comments · Fixed by #906 or #917
Closed

Return error on moduleInfoGet error in VxWorks #886

skliper opened this issue Mar 11, 2021 · 0 comments · Fixed by #906 or #917
Assignees
@jphickey
Labels
CFS-38 enhancement
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Mar 11, 2021

Is your feature request related to a problem? Please describe.
OS_ModuleGetInfo_Impl always returning success in VxWorks:

osal/src/os/vxworks/src/os-impl-loader.c

Lines 175 to 179 in ead5723

vxStatus = moduleInfoGet(impl->moduleID, &vxModuleInfo);
if (vxStatus == ERROR)
{
OS_DEBUG("OSAL: OS_ModuleInfoGet Error from vxWorks: %d\n", vxStatus);
}

Describe the solution you'd like
Return error. It's not like the other cases where other info isn't available and success makes sense.

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC, OSAL code review
@skliper skliper added this to the 6.0.0 milestone Mar 11, 2021
jphickey added a commit to jphickey/osal that referenced this issue Mar 15, 2021
@jphickey
Fix nasa#886, return moduleInfoGet error
1aad679 
Propagate a VxWorks error on moduleInfoGet() call into OS_ERROR return.
@jphickey jphickey mentioned this issue Mar 15, 2021
Merged
astrogeco added a commit that referenced this issue Mar 22, 2021
@astrogeco
Merge pull request #906 from jphickey/fix-886-moduleInfoGet-err
116677b 
Fix #886, return moduleInfoGet error
@astrogeco astrogeco mentioned this issue Mar 22, 2021
Merged
jphickey added a commit to jphickey/osal that referenced this issue Aug 10, 2022
@jphickey
Fix nasa#886, library table management
16e2c0e 
Apply the appid/taskid pattern to Library resources.
No real logic change - just putting repeated logic into
inline functions.
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@yammajamma
Merge pull request nasa#887 from jphickey/fix-886-library-table
36695e9 
Fix nasa#886, library table id management
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
CFS-38 enhancement
Projects
None yet
Milestone
Caelum
2 participants
@jphickey @skliper