Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove FPU and exception handling APIs from OSAL #366

Closed
skliper opened this issue Mar 4, 2020 · 5 comments · Fixed by #415 or #433
Closed

Remove FPU and exception handling APIs from OSAL #366

skliper opened this issue Mar 4, 2020 · 5 comments · Fixed by #415 or #433
Assignees
@skliper
Labels
removed
Milestone
Bootes

Comments

@skliper
Copy link
Contributor

skliper commented Mar 4, 2020

Is your feature request related to a problem? Please describe.
Exception and FPU exception handling only partially implemented in OSAL

Describe the solution you'd like
Remove from OSAL, better suited to PSP if/when fully implemented.

Describe alternatives you've considered
None

Additional context
See also #18 to remove shared memory APIs

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper added this to the 5.1.0 milestone Mar 4, 2020
@skliper skliper mentioned this issue Mar 15, 2020
Closed
skliper added a commit to skliper/osal that referenced this issue Mar 15, 2020
@skliper
Fix nasa#364, Scrub user's guide
4d429de 
Document/comment changes only
Partially addresses nasa#255, nasa#12, nasa#18, nasa#366
@skliper skliper mentioned this issue Mar 15, 2020
Merged
skliper added a commit to skliper/osal that referenced this issue Mar 15, 2020
@skliper
Fix nasa#364, Scrub user's guide
a4abbfc 
Document/comment changes only
Partially addresses nasa#255, nasa#12, nasa#18, nasa#366
@skliper
Copy link
Contributor Author

skliper commented Mar 23, 2020

Note FPUExecAttachHandler, FPUExcEnable and FPUExcDisable also don't have functional tests. Certification issue

@skliper skliper added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Mar 25, 2020
@astrogeco
Copy link
Contributor

CCB 2020-03-25: No objections

@astrogeco astrogeco added CCB - 20200325 and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Mar 25, 2020
skliper added a commit to skliper/osal that referenced this issue Apr 10, 2020
@skliper
Fix nasa#366, Deprecated exception handling APIs
fd76823 
Never fully implemented and more appropriate
in PSP layer due to platform dependencies
skliper added a commit to skliper/osal that referenced this issue Apr 10, 2020
@skliper
Fix nasa#366, Deprecated exception handling APIs
189dca8 
Never fully implemented and more appropriate
in PSP layer due to platform dependencies
@skliper skliper mentioned this issue Apr 10, 2020
Merged
@skliper skliper self-assigned this Apr 10, 2020
@jphickey
Copy link
Contributor

Note that these functions are being called by src/unit-tests/oscore-test/ut_oscore_exception_test.c. As part of PR #427 I was testing by removing the FPU functions and got a link failure about this. Will need to reconcile somehow.

I thought this was CCB approved but it looks like it hasn't been merged to master yet. Is this waiting on anything?

@skliper
Copy link
Contributor Author

skliper commented Apr 21, 2020

@jphickey that test was removed in #415? @astrogeco hasn't merged yet.

@jphickey
Copy link
Contributor

That may explain it - I thought it was merged already. Nonetheless in order for PR #427 to work with OMIT_DEPRECATED set then this is needed, so will need to rebase after this is merged.

skliper added a commit to skliper/osal that referenced this issue Apr 22, 2020
@skliper
Fix nasa#366, Deprecated exception handling APIs
f45f565 
Never fully implemented and more appropriate
in PSP layer due to platform dependencies
astrogeco added a commit that referenced this issue Apr 23, 2020
@astrogeco
Merge pull request #415 from skliper/fix366-dep-fpu-except
9ffab35 
Fix #366, Deprecated exception handling APIs
@astrogeco astrogeco mentioned this issue Apr 27, 2020
Merged
@astrogeco astrogeco linked a pull request Apr 27, 2020 that will close this issue
Integration Candidate: 2020-04-15 #433
Merged
astrogeco pushed a commit that referenced this issue May 1, 2020
@skliper
Fix #366, Deprecated exception handling APIs
b3571d6 
Never fully implemented and more appropriate
in PSP layer due to platform dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skliper skliper

Labels
removed
Projects
None yet
Milestone
Bootes
3 participants
@jphickey @skliper @astrogeco