Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #366, Deprecated exception handling APIs #415

Merged
merged 1 commit into from
Apr 23, 2020

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Apr 10, 2020

Describe the contribution
Deprecates the FPU exception and exception handling APIs

Never fully implemented and more appropriate in PSP layer due to platform dependencies
Note - also removes old interrupt unit test header (missed in interrupt deprecation)
Fixes #366

Testing performed
CI - https://travis-ci.com/github/skliper/cFS/builds/159870030

Expected behavior changes
None

System(s) tested on
CI - with master bundle

Additional context
May need slight mods relative to cmake related to listing c files vs aux

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added enhancement CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Apr 10, 2020
@skliper skliper added this to the 5.1.0 milestone Apr 10, 2020
@skliper
Copy link
Contributor Author

skliper commented Apr 15, 2020

CCB 20200415 - APPROVED

@astrogeco astrogeco added CCB:Approved Indicates code review and approval by community CCB CCB - 20200415 and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Apr 20, 2020
@astrogeco astrogeco changed the base branch from master to integration-candidate April 21, 2020 22:13
@astrogeco
Copy link
Contributor

@skliper can you take a look at the merge conflicts?

Never fully implemented and more appropriate
in PSP layer due to platform dependencies
@skliper
Copy link
Contributor Author

skliper commented Apr 22, 2020

@astrogeco rebased and conflict resolved

@astrogeco astrogeco merged commit 9ffab35 into nasa:integration-candidate Apr 23, 2020
@skliper skliper deleted the fix366-dep-fpu-except branch February 1, 2021 21:36
jphickey added a commit to jphickey/osal that referenced this pull request Aug 10, 2022
Build the CFE UT stub library separately from the test cases.
This moves the stub files into a separate ut-stubs directory,
and the library is now called "ut_cfe_core_stubs"

Note: Minor cleanup also done as part of moving.  Two stub
files were in the source tree but not being built or used
by any framework test config.  These were:
  ut_arinc653_stubs.c
  ut_configdata_stubs.c

These are now removed.  Also cleaned up some old macros/ifdefs
that were never enabled or used in the current tests.
jphickey pushed a commit to jphickey/osal that referenced this pull request Aug 10, 2022
Fix nasa#415, nasa#429
Reviewed and approved at 2019-12-18 CCB
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove FPU and exception handling APIs from OSAL
2 participants