-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #364 and others, Scrub user's guide #371
Merged
astrogeco
merged 4 commits into
nasa:integration-candidate
from
skliper:fix364-userguide-scrub
Mar 23, 2020
Merged
Fix #364 and others, Scrub user's guide #371
astrogeco
merged 4 commits into
nasa:integration-candidate
from
skliper:fix364-userguide-scrub
Mar 23, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skliper
force-pushed
the
fix364-userguide-scrub
branch
from
March 15, 2020 21:00
4d429de
to
a4abbfc
Compare
Replicated changes to old documents that were done previously. Document/comment change only.
Comment/document only
skliper
added
enhancement
CCB:Ready
Pull request is ready for discussion at the Configuration Control Board (CCB)
labels
Mar 15, 2020
See attached results. |
Comment/document only
skliper
changed the title
Fix #364, Scrub user's guide
Fix #364 and others, Scrub user's guide
Mar 16, 2020
CCB Approved - 20200318 |
This was
linked to
issues
Mar 18, 2020
astrogeco
added
CCB - 20200318
CCB:Approved
Indicates code review and approval by community CCB
and removed
CCB:Ready
Pull request is ready for discussion at the Configuration Control Board (CCB)
labels
Mar 18, 2020
This was referenced Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Document/comment changes only
Fix #364 - see issue for detailed changes
Fix #70 - since old doc was removed, and autodoc is correct
Fix #10 - replicated changes to old document in API header comments in 1aa87de
Fix #225 - documented callback restrictions 4b19a1a
Fix #116 - document OS dependent behavior on open files 8f0780e
Partially addresses #255, #12, #18, #366
Testing performed
Steps taken to test the contribution:
Expected behavior changes
No behavior change other than warnings resolved for doc build
System(s) tested on
Additional context
None
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC