Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plots] Gracefully handle Float32Array breaking values #7138

Merged
merged 13 commits into from
Oct 24, 2023

Conversation

jvigliotta
Copy link
Contributor

@jvigliotta jvigliotta commented Oct 12, 2023

Closes #7137
Related: NASA-AMMOS/openmct-mcws#15

Describe your changes:

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes? (follow up due to deadline: [Plots] Test for very large values that break plots #7139)
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@deploysentinel
Copy link

deploysentinel bot commented Oct 12, 2023

Current Playwright Test Results Summary

✅ 14 Passing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 10/24/2023 11:07:30pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: a1d658e

Started: 10/24/2023 11:05:35pm UTC

View Detailed Build Results


Current Playwright Test Results Summary

✅ 147 Passing - ⚠️ 5 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 10/24/2023 11:07:30pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: a1d658e

Started: 10/24/2023 10:52:00pm UTC

⚠️ Flakes

📄   functional/plugins/plot/logPlot.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1Initial Attempt
3.70% (3) 3 / 81 runs
failed over last 7 days
20.99% (17) 17 / 81 runs
flaked over last 7 days

📄   functional/plugins/timer/timer.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Timer Can perform actions on the Timer
Retry 1Initial Attempt
1.32% (1) 1 / 76 run
failed over last 7 days
7.89% (6) 6 / 76 runs
flaked over last 7 days

📄   functional/planning/timelist.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1Initial Attempt
0.89% (1) 1 / 112 run
failed over last 7 days
50.89% (57) 57 / 112 runs
flaked over last 7 days

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1Initial Attempt
7.06% (6) 6 / 85 runs
failed over last 7 days
49.41% (42) 42 / 85 runs
flaked over last 7 days

📄   functional/plugins/notebook/notebookSnapshots.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Snapshot image tests Can drop an image onto a notebook and create a new entry
Retry 1Initial Attempt
2.33% (2) 2 / 86 runs
failed over last 7 days
70.93% (61) 61 / 86 runs
flaked over last 7 days

View Detailed Build Results


@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #7138 (a1d658e) into master (7bf9832) will increase coverage by 0.25%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #7138      +/-   ##
==========================================
+ Coverage   55.41%   55.67%   +0.25%     
==========================================
  Files         651      651              
  Lines       26189    26192       +3     
  Branches     2536     2536              
==========================================
+ Hits        14513    14582      +69     
+ Misses      10979    10903      -76     
- Partials      697      707      +10     
Flag Coverage Δ *Carryforward flag
e2e-full 41.84% <ø> (+0.08%) ⬆️ Carriedforward from 770696a
e2e-stable 57.41% <100.00%> (+<0.01%) ⬆️
unit 49.23% <75.00%> (+0.39%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
example/generator/GeneratorProvider.js 93.54% <ø> (ø)
example/generator/plugin.js 90.00% <ø> (ø)
src/plugins/plot/configuration/PlotSeries.js 86.52% <100.00%> (+0.21%) ⬆️

... and 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bf9832...a1d658e. Read the comment docs.

@jvigliotta jvigliotta changed the title Plot float32 exceed fix [Plots] Gracefully handle Float32Array breaking values Oct 12, 2023
Copy link
Contributor

@shefalijoshi shefalijoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but found an oddity during testing.

@shefalijoshi
Copy link
Contributor

Screen Shot 2023-10-12 at 12 20 44 PM

Notice that the value on the Y axis are positive > 0 but on hovering over the gap, the value shows as -ve. Seems bit odd?

@jvigliotta
Copy link
Contributor Author

Screen Shot 2023-10-12 at 12 20 44 PM Notice that the value on the Y axis are positive > 0 but on hovering over the gap, the value shows as -ve. Seems bit odd?

I agree it is odd, not really sure a way around that though, that point that's missing in that gap, is negative. if we had scaling and were able to plot it, it'd be just a straight line down.

Copy link
Contributor

@davetsay davetsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SWG game is strong

@ozyx ozyx added this to the Target:3.2.0 milestone Oct 23, 2023
@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Oct 23, 2023
@ozyx ozyx enabled auto-merge (squash) October 23, 2023 17:56
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Oct 23, 2023
@ozyx
Copy link
Contributor

ozyx commented Oct 23, 2023

@jvigliotta Looks like there's a new test flake in Plots e2e

@ozyx ozyx disabled auto-merge October 23, 2023 18:07
@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Oct 24, 2023
@ozyx ozyx enabled auto-merge (squash) October 24, 2023 23:02
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Oct 24, 2023
@ozyx ozyx merged commit d94fe88 into master Oct 24, 2023
14 of 15 checks passed
@ozyx ozyx deleted the plot-float32-exceed-fix branch October 24, 2023 23:07
@ozyx ozyx removed this from the Target:3.2.0 milestone Oct 24, 2023
@unlikelyzero unlikelyzero added this to the Target:3.2.0 milestone Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Plots] Very large values cause entire plot to disappear
5 participants