-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Plots] Gracefully handle Float32Array breaking values #7138
Conversation
Current Playwright Test Results Summary✅ 14 Passing Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 10/24/2023 11:07:30pm UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: a1d658e Started: 10/24/2023 11:05:35pm UTC Current Playwright Test Results Summary✅ 147 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 10/24/2023 11:07:30pm UTC)
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1 • Initial Attempt |
3.70% (3)3 / 81 runsfailed over last 7 days |
20.99% (17)17 / 81 runsflaked over last 7 days |
📄 functional/plugins/timer/timer.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Timer Can perform actions on the Timer
Retry 1 • Initial Attempt |
1.32% (1)1 / 76 runfailed over last 7 days |
7.89% (6)6 / 76 runsflaked over last 7 days |
📄 functional/planning/timelist.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1 • Initial Attempt |
0.89% (1)1 / 112 runfailed over last 7 days |
50.89% (57)57 / 112 runsflaked over last 7 days |
📄 functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1 • Initial Attempt |
7.06% (6)6 / 85 runsfailed over last 7 days |
49.41% (42)42 / 85 runsflaked over last 7 days |
📄 functional/plugins/notebook/notebookSnapshots.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Snapshot image tests Can drop an image onto a notebook and create a new entry
Retry 1 • Initial Attempt |
2.33% (2)2 / 86 runsfailed over last 7 days |
70.93% (61)61 / 86 runsflaked over last 7 days |
Codecov Report
@@ Coverage Diff @@
## master #7138 +/- ##
==========================================
+ Coverage 55.41% 55.67% +0.25%
==========================================
Files 651 651
Lines 26189 26192 +3
Branches 2536 2536
==========================================
+ Hits 14513 14582 +69
+ Misses 10979 10903 -76
- Partials 697 707 +10
*This pull request uses carry forward flags. Click here to find out more.
... and 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, but found an oddity during testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SWG game is strong
@jvigliotta Looks like there's a new test flake in Plots e2e |
Closes #7137
Related: NASA-AMMOS/openmct-mcws#15
Describe your changes:
All Submissions:
Author Checklist
Reviewer Checklist