Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plots] Very large values cause entire plot to disappear #7137

Closed
3 of 7 tasks
jvigliotta opened this issue Oct 12, 2023 · 3 comments · Fixed by #7138
Closed
3 of 7 tasks

[Plots] Very large values cause entire plot to disappear #7137

jvigliotta opened this issue Oct 12, 2023 · 3 comments · Fixed by #7138
Labels
Milestone

Comments

@jvigliotta
Copy link
Contributor

jvigliotta commented Oct 12, 2023

Summary

When there is a very large telemetry value (in this case -7.5e+177) within the time range, the VISTA plot is blank, even though there are data points in the range. This example is for a short time range, but if you expand the time boundaries (e.g. over a week or more), you will see that the whole plot is blank. This makes it seem like data is missing, but it’s a plotting bug.

Follow up for test: #7139

Expected vs Current Behavior

At the very least the rest of the plot should still be plotted.

Steps to Reproduce

  1. View a plot with values that would break a Float32Array (we have an option for this in the sine wave generator)
  2. Once a value that exceeds Float32Array capabilities (Above 3.4+38, Below -3.4+38) appears in the plot, the whole thing disappears

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available? (viewing in log mode, which is basically useless at these ranges)
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?
@jvigliotta
Copy link
Contributor Author

Testing

  • follow the reproduction steps
  • with the fix, you should see gaps in the plot and if you hove over them, you should see the values that are missing

@ozyx ozyx added this to the Target:3.2.0 milestone Oct 23, 2023
@khalidadil
Copy link
Contributor

Verified Fixed in Testathon on 10/26/23

@ozyx ozyx modified the milestones: Target:3.2.1, Target:3.2.0 Nov 13, 2023
@ozyx
Copy link
Contributor

ozyx commented Nov 13, 2023

Verified Testathon 11/13/23, plots don't disappear, only small gaps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants