Integration Candidate - 20200311 #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids the two path diverging and possibly causing problems in the future
Resolved issues with generating pdf user's guide
Fix issue regarding inclusion of cfe_platform_cfg.h when multiple CPUs are in use. Also fix for duplicate name collision where different configs exist within the same arch.
Updated the cFE app developer's guide markdown with changes to resolve issues 499, 496, and 478. Made a variety of other small content updates and reordered some sections.
- Remove old document - Add title - Arrange table of contents for consistency
Use SRC_LOCAL_PATH as single source of truth
Fix #539, build failure in UT stubs with multiple CPUs
Updated cFE App Developer's Guide
This was
linked to
issues
Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fixes #478, #499, #496, #535, #537, and #539
Also adds PR #458
Testing performed
See PRs #458, #538, #542, #545
CI on cfs-bundle integration candidate, see nasa/cFS#57
Expected behavior changes
PR #458 - Prevents the call to file(TO_NATIVE_PATH ...) from building its own path with content identical to SRC_LOCAL_PATH.
PR #538 - PDF users guide can be generated by make process
PR #542 - Removes dependencies on cfe_platform_cfg.h from the unit test stub code. Fixes a name collision where different configs exist within the same architecture.
PR #545 - Documentation Only
System(s) tested on
See PRs above
CI: Ubuntu:Bionic
Additional context
See PRs above
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC
Elizabeth Timmons - NASA/GSFC
Joseph Hickey - Vantage Systems, Inc. (CLA on File)
Andrei-Costin Zisu - Planetary Transportation Systems GmbH (CLA on File)