Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test build fails when multiple CPUs are defined #539

Closed
jphickey opened this issue Mar 3, 2020 · 0 comments · Fixed by #542 or #563
Closed

Unit test build fails when multiple CPUs are defined #539

jphickey opened this issue Mar 3, 2020 · 0 comments · Fixed by #542 or #563
Assignees
@jphickey
Labels
bug
Milestone
Bootes

Comments

@jphickey
Copy link
Contributor

jphickey commented Mar 3, 2020

Describe the bug
After updating some projects to the latest baseline, getting a new build failure:

[ 73%] Building C object ut_cfe_core_stubs/CMakeFiles/ut_cfe-core_stubs.dir/ut_es_stubs.c.o
cfe/fsw/cfe-core/ut-stubs/ut_es_stubs.c:37:10: fatal error: cfe_platform_cfg.h: No such file or directory
 #include "cfe_platform_cfg.h"
          ^~~~~~~~~~~~~~~~~~~~
compilation terminated.

To Reproduce
The configuration of this project uses multiple CPUs that all share the same architecture (PPC) but different platform configs (cfe_platform_cfg.h).

Expected behavior
Build should succeed

System observed on:

  • Ubuntu 18.04 LTS 64-bit (build host)
  • Cross Compiling for PPC (embedded Linux)
  • Latest "master" baseline (2020-02-26)

Additional context
This is related to a recent change that separated the UT stubs from the CFE. It works fine with only a single CPU/config, but if multiple CPUs are defined then this fails. Unfortunately only testing this now - the CI/CD build only uses a single CPU/config.

Need to remove UT dependencies on a specific "cfe_platform_cfg.h" to fix this. (stubs should not need this file, it is not a real implementation, it is just stubs).

Reporter Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey added the bug label Mar 3, 2020
@jphickey jphickey self-assigned this Mar 3, 2020
jphickey added a commit to jphickey/cFE that referenced this issue Mar 4, 2020
@jphickey
Fix nasa#539, Build failure in UT stubs with multiple CPUs
8df69e9 
Fix issue regarding inclusion of cfe_platform_cfg.h when
multiple CPUs are in use.  Also fix for duplicate name
collision where different configs exist within the same
arch.
@jphickey jphickey mentioned this issue Mar 4, 2020
Merged
astrogeco added a commit that referenced this issue Mar 18, 2020
@astrogeco
Merge pull request #542 from jphickey/fix-539-ut-buildfail
1978d64 
Fix #539, build failure in UT stubs with multiple CPUs
@astrogeco astrogeco mentioned this issue Mar 18, 2020
Merged
@astrogeco astrogeco linked a pull request Mar 18, 2020 that will close this issue
Integration Candidate - 20200311 #563
Merged
lbleier-GSFC pushed a commit to lbleier-GSFC/cFE that referenced this issue Apr 6, 2020
@jphickey @lbleier-GSFC
Fix nasa#539, Build failure in UT stubs with multiple CPUs
7f2bdfa 
Fix issue regarding inclusion of cfe_platform_cfg.h when
multiple CPUs are in use.  Also fix for duplicate name
collision where different configs exist within the same
arch.
@skliper skliper added this to the 6.8.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
bug
Projects
None yet
Milestone
Bootes
2 participants
@jphickey @skliper