-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #2196, resolve static analysis errors in tbl_UT.c #2197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running the latest static analysis workflow revealed the following additional style errors (this is from the "strict" set that does not occur at the bundle level workflow).
|
Clean cppcheck run observed in: https://github.com/nasa/cFE/actions/runs/3386994564 |
jphickey
force-pushed
the
fix-2196-cppcheck
branch
from
November 3, 2022 15:30
5e3b1a7
to
660590b
Compare
Resolves two uninitialized variable errors reported in the workflow, and other minor style items. Add suppressions for endian checks which are constant on a given arch.
jphickey
force-pushed
the
fix-2196-cppcheck
branch
from
November 3, 2022 15:31
660590b
to
562dd29
Compare
Updated commit includes style fixes, so this should pass static analysis after nasa/cFS#607 gets merged. |
jphickey
added
the
CCB:Ready
Ready for discussion at the Configuration Control Board (CCB)
label
Nov 3, 2022
dzbaker
added
CCB:Approved
Indicates code review and approval by community CCB
and removed
CCB:Ready
Ready for discussion at the Configuration Control Board (CCB)
labels
Nov 3, 2022
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Nov 14, 2022
*Combines:* cfe v7.0.0-rc4+dev205 osal v6.0.0-rc4+dev151 cFS-GroundSystem v3.0.0-rc4+dev39 **Includes:** *cFS* - #608 *cFE* - nasa/cFE#2197 *osal* - nasa/osal#1323 *cFS-GroundSystem* - nasa/cFS-GroundSystem#217 - nasa/cFS-GroundSystem#230 Co-authored by: Joseph Hickey <[email protected]> Co-authored-by: Avi Weiss <[email protected]> Co-authored-by: Paul Ober <[email protected]>
This was referenced Nov 14, 2022
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Nov 14, 2022
*Combines:* cfe v7.0.0-rc4+dev205 osal v6.0.0-rc4+dev151 cFS-GroundSystem v3.0.0-rc4+dev39 **Includes:** *cFS* - #608 *cFE* - nasa/cFE#2197 *osal* - nasa/osal#1323 *cFS-GroundSystem* - nasa/cFS-GroundSystem#217 - nasa/cFS-GroundSystem#230 Co-authored by: Joseph Hickey <[email protected]> Co-authored-by: Avi Weiss <[email protected]> Co-authored-by: Paul Ober <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Resolves two uninitialized variable errors reported in the workflow.
Fixes #2196
Testing performed
Build and run all tests
Run workflow
Expected behavior changes
Passes static analysis, no behavior change.
System(s) tested on
Updated Github workflow (with nasa/cFS#607)
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.