Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #202, naming error #217

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Fix #202, naming error #217

merged 1 commit into from
Nov 14, 2022

Conversation

paulober
Copy link
Contributor

Sorry for that. Missed that one in conversion...

Describe the contribution

Contributor Info - All information REQUIRED for consideration of pull request
Personal

@skliper
Copy link
Contributor

skliper commented Sep 6, 2022

On Ubuntu20.04 I still get:

Traceback (most recent call last):
  File "/home/jhageman/cFS/cFS-GitHub/tools/cFS-GroundSystem/Subsystems/tlmGUI/GenericTelemetry.py", line 253, in <module>
    telem.init_gt_tlm_receiver(subscription)
  File "/home/jhageman/cFS/cFS-GitHub/tools/cFS-GroundSystem/Subsystems/tlmGUI/GenericTelemetry.py", line 88, in init_gt_tlm_receiver
    self.thread.gtSignalTlmDatagram.connect(self.process_pending_datagrams)
AttributeError: 'GTTlmReceiver' object has no attribute 'gtSignalTlmDatagram'

@paulober
Fix nasa#202, naming error
86914b7 
Sorry for that

Fixed other error
@paulober
Copy link
Contributor Author

paulober commented Sep 7, 2022

On Ubuntu20.04 I still get:

Traceback (most recent call last):
  File "/home/jhageman/cFS/cFS-GitHub/tools/cFS-GroundSystem/Subsystems/tlmGUI/GenericTelemetry.py", line 253, in <module>
    telem.init_gt_tlm_receiver(subscription)
  File "/home/jhageman/cFS/cFS-GitHub/tools/cFS-GroundSystem/Subsystems/tlmGUI/GenericTelemetry.py", line 88, in init_gt_tlm_receiver
    self.thread.gtSignalTlmDatagram.connect(self.process_pending_datagrams)
AttributeError: 'GTTlmReceiver' object has no attribute 'gtSignalTlmDatagram'

Should be fixed now.

@skliper
Copy link
Contributor

skliper commented Sep 8, 2022

I still get the following errors (and the window doesn't open) when trying to open the ES HK Tlm page. Maybe I have a more fundamental issue?

Generic Telemetry Page started. Subscribed to GroundSystem.0x800
qt.qpa.xcb: X server does not support XInput 2
failed to get the current screen resources
QStandardPaths: XDG_RUNTIME_DIR not set, defaulting to '/tmp/runtime-jhageman'
qt.qpa.xcb: QXcbConnection: XCB error: 1 (BadRequest), sequence: 164, resource id: 90, major code: 130 (Unknown), minor code: 47
qt.qpa.xcb: QXcbConnection: XCB error: 170 (Unknown), sequence: 177, resource id: 90, major code: 146 (Unknown), minor code: 20
Traceback (most recent call last):
  File "/home/jhageman/cFS/cFS-GitHub/tools/cFS-GroundSystem/Subsystems/tlmGUI/GenericTelemetry.py", line 110, in process_pending_datagrams
    self.display_telemetry_item(datagram, k, item_label, item_value)
  File "/home/jhageman/cFS/cFS-GitHub/tools/cFS-GroundSystem/Subsystems/tlmGUI/GenericTelemetry.py", line 77, in display_telemetry_item
    value_field.setText(tlm_item_enum[tlm_index][int(tlm_field[0])])
IndexError: list index out of range

@skliper skliper added the CCB:Ignore Pull Request is NOT ready for discussion. Has open actions. Will be re-examined at by next CCB. label Sep 8, 2022
@skliper
Copy link
Contributor

skliper commented Sep 8, 2022

Adding CCB:Ignore label for now until issues are resolved.

@paulober
Copy link
Contributor Author

paulober commented Sep 8, 2022

I still get the following errors (and the window doesn't open) when trying to open the ES HK Tlm page. Maybe I have a more fundamental issue?
[...]

Traceback (most recent call last):
  File "/home/jhageman/cFS/cFS-GitHub/tools/cFS-GroundSystem/Subsystems/tlmGUI/GenericTelemetry.py", line 110, in process_pending_datagrams
    self.display_telemetry_item(datagram, k, item_label, item_value)
  File "/home/jhageman/cFS/cFS-GitHub/tools/cFS-GroundSystem/Subsystems/tlmGUI/GenericTelemetry.py", line 77, in display_telemetry_item
    value_field.setText(tlm_item_enum[tlm_index][int(tlm_field[0])])
IndexError: list index out of range

🤔 strange, I just tested it on a new VM and it opens the window without any warnings or errors.

@skliper
Copy link
Contributor

skliper commented Sep 8, 2022

I'll try to take a closer look at it... just did a quick initial check.

@skliper skliper self-assigned this Sep 8, 2022
@skliper
Copy link
Contributor

skliper commented Sep 26, 2022

OK, looks like this does fix #217. I was able to open both TBL and TIME HK pages. There's still an error with opening ES, I suspect the packet description is out of date. I'll open a new issue for that, but this change should be able to move forward.

@skliper skliper added CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) and removed CCB:Ignore Pull Request is NOT ready for discussion. Has open actions. Will be re-examined at by next CCB. labels Sep 26, 2022
This was referenced Sep 26, 2022
Open
Open
@skliper skliper removed their assignment Sep 26, 2022
@chillfig
Copy link
Contributor

Approved. Just needs confirmation on contributor license agreement (cla). @paulober would you please confirm that you emailed in a cla?

@paulober
Copy link
Contributor Author

Approved. Just needs confirmation on contributor license agreement (cla). @paulober would you please confirm that you emailed in a cla?

Confirm signed it allready.

@chillfig chillfig added CCB:Approved Indicates approval by CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Sep 30, 2022
@skliper
Copy link
Contributor

skliper commented Nov 9, 2022

@dzbaker @chillfig What's the status on this one? It's currently broken without it...

@chillfig
Copy link
Contributor

@dzbaker @chillfig What's the status on this one? It's currently broken without it...

This pull request looks good to me to merge. @dzbaker is out of office until November 14. Can the merge wait until then?

dzbaker added a commit to nasa/cFS that referenced this pull request Nov 14, 2022
@dzbaker
IC: Caelum-rc4+dev28
b041cdf 
*Combines:*

cfe v7.0.0-rc4+dev205
osal v6.0.0-rc4+dev151
cFS-GroundSystem v3.0.0-rc4+dev39

**Includes:**

*cFS*
- #608

*cFE*
- nasa/cFE#2197

*osal*
- nasa/osal#1323

*cFS-GroundSystem*
- nasa/cFS-GroundSystem#217
- nasa/cFS-GroundSystem#230

Co-authored by: Joseph Hickey <[email protected]>
Co-authored-by: Avi Weiss <[email protected]>
Co-authored-by: Paul Ober <[email protected]>
This was referenced Nov 14, 2022
Merged
Merged
@dzbaker dzbaker merged commit 949be4b into nasa:main Nov 14, 2022
dzbaker added a commit to nasa/cFS that referenced this pull request Nov 14, 2022
@dzbaker
IC: Caelum-rc4+dev28
aa2755c 
*Combines:*

cfe v7.0.0-rc4+dev205
osal v6.0.0-rc4+dev151
cFS-GroundSystem v3.0.0-rc4+dev39

**Includes:**

*cFS*
- #608

*cFE*
- nasa/cFE#2197

*osal*
- nasa/osal#1323

*cFS-GroundSystem*
- nasa/cFS-GroundSystem#217
- nasa/cFS-GroundSystem#230

Co-authored by: Joseph Hickey <[email protected]>
Co-authored-by: Avi Weiss <[email protected]>
Co-authored-by: Paul Ober <[email protected]>
@dzbaker
Copy link
Contributor

dzbaker commented Nov 14, 2022

@dzbaker @chillfig What's the status on this one? It's currently broken without it...

This pull request looks good to me to merge. @dzbaker is out of office until November 14. Can the merge wait until then?

@skliper @chillfig Merged!

@paulober paulober deleted the fix-202-var-name-errors branch November 14, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CCB:Approved Indicates approval by CCB
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Telemetry GUI error - Individual telemetry pages do not open due to name errors in GenericTelemetry.py
4 participants
@paulober @skliper @chillfig @dzbaker