Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cFE Integration candidate: Caelum-rc4+dev33 #2232

Merged
merged 8 commits into from
Dec 20, 2022
Merged

cFE Integration candidate: Caelum-rc4+dev33 #2232

merged 8 commits into from
Dec 20, 2022

Conversation

dzbaker
Copy link
Collaborator

@dzbaker dzbaker commented Dec 20, 2022 •
edited
Loading

Checklist (Please check before submitting)

Describe the contribution

Testing performed
cFS Bundle Checks
cFE Checks

Expected behavior changes
See PRs

System(s) tested on
Ubuntu 20.04

Additional context
Add any other context about the contribution here.

Third party code
If included, identify any third party code and provide text file of license

Contributor Info - All information REQUIRED for consideration of pull request
@dmknutsen
@jphickey
@thnkslprpt

thnkslprpt and others added 8 commits December 1, 2022 10:30
@thnkslprpt
Fix #2174, Move CRC types and convert to enum
ed4722b
Fix #2228, Update UTs to use correct cmd types
4f4d492 
Fix #2228, Update UTs to use correct cmd types
@jphickey
Fix #2228, Use correct message types
0f9313d 
Update remaining cases where the CFE_MSG_CommandHeader_t was used for a
command that had no arguments, replacing it with a real data type that
is named according to the command.

In particular, this introduces a "SendHkCmd" type into all modules,
where previously the HK command used CFE_MSG_CommandHeader_t directly.
@jphickey
Fix #2230, EDS Updates to match the current mainline
a3013c9 
This includes all the updates to EDS XML files since the Bootes release
where they were last synced.  This includes EDS files for modules that
did not yet have one, and updating the other files to match the current
message structures in Draco.
@dzbaker
Merge pull request #2231 from jphickey/fix-2230-eds-update
5ad31f1 
Fix #2230, EDS Updates to match the current mainline
@dzbaker
Merge pull request #2229 from dmknutsen/ISSUE_2228
9b047b8 
Fix #2228, Update UTs to use correct cmd types
@dzbaker
Merge pull request #2192 from thnkslprpt/fix-2174-move-crc-types-into…
d666214 
…-enum

Fix #2174, Move CRC types and convert to enum
@dzbaker
Bump to v7.0.0-rc4+dev242
bb60c19
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 20, 2022
View reviewed changes
modules/es/fsw/src/cfe_es_api.c
@@ -1571,7 +1571,7 @@
* See description in header file for argument/return detail
*
*-----------------------------------------------------------------*/
uint32 CFE_ES_CalculateCRC(const void *DataPtr, size_t DataLength, uint32 InputCRC, uint32 TypeCRC)
uint32 CFE_ES_CalculateCRC(const void *DataPtr, size_t DataLength, uint32 InputCRC, CFE_ES_CrcType_Enum_t TypeCRC)

Check notice

Code scanning / CodeQL-coding-standard

Long function without assertion

All functions of more than 10 lines should have at least one assertion.
modules/es/fsw/src/cfe_es_api.c
@@ -1571,7 +1571,7 @@
* See description in header file for argument/return detail
*
*-----------------------------------------------------------------*/
uint32 CFE_ES_CalculateCRC(const void *DataPtr, size_t DataLength, uint32 InputCRC, uint32 TypeCRC)
uint32 CFE_ES_CalculateCRC(const void *DataPtr, size_t DataLength, uint32 InputCRC, CFE_ES_CrcType_Enum_t TypeCRC)

Check notice

Code scanning / CodeQL-coding-standard

Function too long

CFE_ES_CalculateCRC has too many lines (69, while 60 are allowed).
modules/core_api/ut-stubs/src/cfe_es_stubs.c
@@ -77,14 +77,14 @@
* Generated stub function for CFE_ES_CalculateCRC()
* ----------------------------------------------------
*/
uint32 CFE_ES_CalculateCRC(const void *DataPtr, size_t DataLength, uint32 InputCRC, uint32 TypeCRC)
uint32 CFE_ES_CalculateCRC(const void *DataPtr, size_t DataLength, uint32 InputCRC, CFE_ES_CrcType_Enum_t TypeCRC)

Check notice

Code scanning / CodeQL-coding-standard

Long function without assertion

All functions of more than 10 lines should have at least one assertion.
modules/core_api/ut-stubs/src/cfe_es_stubs.c
@@ -77,14 +77,14 @@
* Generated stub function for CFE_ES_CalculateCRC()
* ----------------------------------------------------
*/
uint32 CFE_ES_CalculateCRC(const void *DataPtr, size_t DataLength, uint32 InputCRC, uint32 TypeCRC)
uint32 CFE_ES_CalculateCRC(const void *DataPtr, size_t DataLength, uint32 InputCRC, CFE_ES_CrcType_Enum_t TypeCRC)

Check notice

Code scanning / CodeQL-coding-standard

Function too long

CFE_ES_CalculateCRC has too many lines (69, while 60 are allowed).
modules/es/fsw/src/cfe_es_task.c
@@ -655,7 +655,7 @@
* See description in header file for argument/return detail
*
*-----------------------------------------------------------------*/
int32 CFE_ES_HousekeepingCmd(const CFE_MSG_CommandHeader_t *data)
int32 CFE_ES_HousekeepingCmd(const CFE_ES_SendHkCmd_t *data)

Check notice

Code scanning / CodeQL-coding-standard

Long function without assertion

All functions of more than 10 lines should have at least one assertion.
modules/evs/fsw/src/cfe_evs_task.c
@@ -613,7 +613,7 @@
* See description in header file for argument/return detail
*
*-----------------------------------------------------------------*/
int32 CFE_EVS_ReportHousekeepingCmd(const CFE_MSG_CommandHeader_t *data)
int32 CFE_EVS_ReportHousekeepingCmd(const CFE_EVS_SendHkCmd_t *data)

Check notice

Code scanning / CodeQL-coding-standard

Long function without assertion

All functions of more than 10 lines should have at least one assertion.
modules/sb/fsw/src/cfe_sb_task.c
@@ -503,7 +503,7 @@
* See description in header file for argument/return detail
*
*-----------------------------------------------------------------*/
int32 CFE_SB_SendHKTlmCmd(const CFE_MSG_CommandHeader_t *data)
int32 CFE_SB_SendHKTlmCmd(const CFE_SB_SendHkCmd_t *data)

Check notice

Code scanning / CodeQL-coding-standard

Long function without assertion

All functions of more than 10 lines should have at least one assertion.
modules/es/fsw/src/cfe_es_task.c
@@ -655,7 +655,7 @@
* See description in header file for argument/return detail
*
*-----------------------------------------------------------------*/
int32 CFE_ES_HousekeepingCmd(const CFE_MSG_CommandHeader_t *data)
int32 CFE_ES_HousekeepingCmd(const CFE_ES_SendHkCmd_t *data)

Check notice

Code scanning / CodeQL-coding-standard

Function too long

CFE_ES_HousekeepingCmd has too many lines (106, while 60 are allowed).
@dzbaker dzbaker merged commit f6432f5 into main Dec 20, 2022
@dmknutsen dmknutsen added this to the Draco milestone Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
draco-rc4
Projects
None yet
Milestone
Draco
Development

Successfully merging this pull request may close these issues.
4 participants
@dzbaker @dmknutsen @thnkslprpt @jphickey