Fix #1689, Add time arithmetic functional tests #1715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nmullane check format. Might want to enable actions on your fork to catch these |
nmullane
force-pushed
the
fix1689-time-arithmetic-functional-tests
branch
from
5aea2f6
to
a349226
Compare
zanzaben
suggested changes
Jul 27, 2021
| CFE_TIME_SysTime_t time2 = {0, 1000}; | ||
| CFE_TIME_SysTime_t timeAdded = CFE_TIME_Add(time1, time2); | ||
|
|
||
| UtAssert_UINT32_EQ(timeAdded.Seconds, 1000); |
There was a problem hiding this comment.
Instead of checking if it equqals 1000, you should create a timeExpected var and compare to that.
nmullane
commented
Jul 27, 2021
zanzaben
approved these changes
Jul 27, 2021
nmullane
force-pushed
the
fix1689-time-arithmetic-functional-tests
branch
from
309ac45
to
ced6110
Compare
Add tests for * CFE_TIME_Add * CFE_TIME_Subtract * CFE_TIME_Compare
nmullane
force-pushed
the
fix1689-time-arithmetic-functional-tests
branch
from
ced6110
to
b277a2c
Compare
astrogeco
added
the
CCB:Ready
astrogeco
added
CCB:Approved
|
CCB:2021-07-28 APPROVED |
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jul 28, 2021
nasa/cFE#1720, Requirements update for Caelum nasa/cFE#1721, Add null check to CFE_ES_TaskID_ToIndex. nasa/cFE#1719, scrub command documentation nasa/cFE#1715, Add time arithmetic functional tests
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jul 29, 2021
Combines: nasa/cFE#1701, v6.8.0-rc1+dev789 nasa/osal#1116, v5.1.0-rc1+dev578 nasa/cFS-GroundSystem#192, v2.2.0-rc1+dev58 Includes: **cFE** nasa/cFE#1699, correct return code check nasa/cFE#1700, documentation for FS APIs that return OSAL codes nasa/cFE#1695, Adding coverage tests for cfe_es_apps.c nasa/cFE#1673, Add File Utility Functional Tests. nasa/cFE#1711, Add custom epoch support to TIME UT nasa/cFE#1720, Requirements update for Caelum nasa/cFE#1721, Add null check to CFE_ES_TaskID_ToIndex. nasa/cFE#1719, scrub command documentation nasa/cFE#1715, Add time arithmetic functional tests nasa/cFE#1704, update docs for CFE_FS_BackgroundFileDumpRequest nasa/cFE#1706, correct return code mismatches **osal** nasa/osal#1114, Add unit test branch coverage **cFS-GroundSystem** nasa/cFS-GroundSystem#185, Update tlm for ES Blockstats/memstats and TBL HK nasa/cFS-GroundSystem#188, * might be referenced before assignment Co-authored-by: Jacob Hageman <[email protected]> Co-authored-by: Joseph Hickey <[email protected]> Co-authored-by: Alex Campbell <[email protected]> Co-authored-by: Jose F Martinez Pedraza <[email protected]> Co-authored-by: Niall Mullane <[email protected]> Co-authored-by: Paul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
A clear and concise description of what the contribution is.
Testing performed
Steps taken to test the contribution:
Expected behavior changes
A clear and concise description of how this contribution will change behavior and level of impact.
System(s) tested on
Contributor Info - All information REQUIRED for consideration of pull request
Niall Mullane - GSFC 582 Intern