Fix #1703, update docs for CFE_FS_BackgroundFileDumpRequest #1704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jphickey
force-pushed
the
fix-1703-bgfiledump-doc
branch
from
7c1e39e
to
137dcea
Compare
Update notes to better clarify that the meta object must persist for the duration of the dump operation, which occurs in another task, so it must not be on the stack. Also update documentation for background even callbacks to better clarify arguments and expectations of the implementation.
jphickey
force-pushed
the
fix-1703-bgfiledump-doc
branch
from
137dcea
to
05e8904
Compare
skliper
approved these changes
Jul 26, 2021
jphickey
added
the
CCB:Ready
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jul 29, 2021
nasa/cFE#1704, update docs for CFE_FS_BackgroundFileDumpRequest nasa/cFE#1706, correct return code mismatches
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jul 29, 2021
Combines: nasa/cFE#1701, v6.8.0-rc1+dev789 nasa/osal#1116, v5.1.0-rc1+dev578 nasa/cFS-GroundSystem#192, v2.2.0-rc1+dev58 Includes: **cFE** nasa/cFE#1699, correct return code check nasa/cFE#1700, documentation for FS APIs that return OSAL codes nasa/cFE#1695, Adding coverage tests for cfe_es_apps.c nasa/cFE#1673, Add File Utility Functional Tests. nasa/cFE#1711, Add custom epoch support to TIME UT nasa/cFE#1720, Requirements update for Caelum nasa/cFE#1721, Add null check to CFE_ES_TaskID_ToIndex. nasa/cFE#1719, scrub command documentation nasa/cFE#1715, Add time arithmetic functional tests nasa/cFE#1704, update docs for CFE_FS_BackgroundFileDumpRequest nasa/cFE#1706, correct return code mismatches **osal** nasa/osal#1114, Add unit test branch coverage **cFS-GroundSystem** nasa/cFS-GroundSystem#185, Update tlm for ES Blockstats/memstats and TBL HK nasa/cFS-GroundSystem#188, * might be referenced before assignment Co-authored-by: Jacob Hageman <[email protected]> Co-authored-by: Joseph Hickey <[email protected]> Co-authored-by: Alex Campbell <[email protected]> Co-authored-by: Jose F Martinez Pedraza <[email protected]> Co-authored-by: Niall Mullane <[email protected]> Co-authored-by: Paul <[email protected]>
|
CCB:2021-08-04 APPROVED |
astrogeco
added
CCB:Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Update notes to better clarify that the meta object must persist for the duration of the dump operation, which occurs in another task, so it must not be on the stack.
Fixes #1703
Testing performed
Build and run all tests
Expected behavior changes
None - documentation only
System(s) tested on
Ubuntu
Additional context
Noted in PR #1650 which allocated meta object on stack during test (producing weird/unpredictable errors)
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.