Fix #1659, Add custom epoch support to TIME UT #1711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skliper
requested changes
Jul 26, 2021
pepepr08
force-pushed
the
fix1659-time-ut
branch
3 times, most recently
from
0a83b4a
to
4f8246d
Compare
pepepr08
force-pushed
the
fix1659-time-ut
branch
from
4f8246d
to
17861ce
Compare
pepepr08
added
the
CCB:Ready
|
Does time_current_test.c also need to be updated? |
No need to update time_current_test.c. That file uses CFE_TIME_Print, but it only uses it to print out the time to log. It doesn't Assert the return value. |
skliper
approved these changes
Jul 27, 2021
|
@excaliburtb This is the time test fix for your custom EPOCH. |
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jul 27, 2021
nasa/cFE#1673, Add File Utility Functional Tests. nasa/cFE#1711, Add custom epoch support to TIME UT
astrogeco
added
CCB:Approved
|
CCB:2021-07-28 APPROVED with Changes
|
Test overrides configured leap seconds, so no change needed. |
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jul 29, 2021
Combines: nasa/cFE#1701, v6.8.0-rc1+dev789 nasa/osal#1116, v5.1.0-rc1+dev578 nasa/cFS-GroundSystem#192, v2.2.0-rc1+dev58 Includes: **cFE** nasa/cFE#1699, correct return code check nasa/cFE#1700, documentation for FS APIs that return OSAL codes nasa/cFE#1695, Adding coverage tests for cfe_es_apps.c nasa/cFE#1673, Add File Utility Functional Tests. nasa/cFE#1711, Add custom epoch support to TIME UT nasa/cFE#1720, Requirements update for Caelum nasa/cFE#1721, Add null check to CFE_ES_TaskID_ToIndex. nasa/cFE#1719, scrub command documentation nasa/cFE#1715, Add time arithmetic functional tests nasa/cFE#1704, update docs for CFE_FS_BackgroundFileDumpRequest nasa/cFE#1706, correct return code mismatches **osal** nasa/osal#1114, Add unit test branch coverage **cFS-GroundSystem** nasa/cFS-GroundSystem#185, Update tlm for ES Blockstats/memstats and TBL HK nasa/cFS-GroundSystem#188, * might be referenced before assignment Co-authored-by: Jacob Hageman <[email protected]> Co-authored-by: Joseph Hickey <[email protected]> Co-authored-by: Alex Campbell <[email protected]> Co-authored-by: Jose F Martinez Pedraza <[email protected]> Co-authored-by: Niall Mullane <[email protected]> Co-authored-by: Paul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fixes #1659
CFE_TIME_Printis only function that uses the epoch defines. Avoid use ofCFE_TIME_Printto test other Time functions and specifically check for the expected seconds and subseconds.CFE_TIME_Printwith a custom epoch.Testing performed
[ PASS] 06.001 time_UT.c:847 - String: '1980-001-00:00:00.00000' == '1980-001-00:00:00.00000'[ MIR] 06.001 time_UT.c:851 - (MIR) Confirm adding seconds = 0, subseconds = 0 to configured EPOCH results in time 1980-001-00:00:09.00000Expected behavior changes
Time unit tests will now pass, even when project is using a custom epoch time.
System(s) tested on
Contributor Info - All information REQUIRED for consideration of pull request
Jose F. Martinez Pedraza / NASA GSFC