Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spacecraft ID sample setting in targets.cmake should be 0x42 #828

Closed
skliper opened this issue Aug 21, 2020 · 0 comments · Fixed by #829
Closed

Spacecraft ID sample setting in targets.cmake should be 0x42 #828

skliper opened this issue Aug 21, 2020 · 0 comments · Fixed by #829
Assignees
@skliper
Labels
bug build-system cFS-Bootes
Milestone
Bootes

Comments

@skliper
Copy link
Contributor

skliper commented Aug 21, 2020

Is your feature request related to a problem? Please describe.
Historically sample spacecraft ID has been 0x42, when converting to cmake it became 42 (decimal)... this leads to errors in toolchains expecting the historical value.

Describe the solution you'd like
Change to 0x42

Describe alternatives you've considered
None

Additional context
#710

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper mentioned this issue Aug 21, 2020
Closed
skliper added a commit to skliper/cFE that referenced this issue Aug 21, 2020
@skliper
Fix nasa#828, Spacecraft ID sample set to historical value (0x42)
b15c4e5
@skliper skliper mentioned this issue Aug 21, 2020
Merged
@skliper skliper self-assigned this Aug 21, 2020
@skliper skliper mentioned this issue Aug 21, 2020
Merged
@astrogeco astrogeco mentioned this issue Aug 26, 2020
Closed
@skliper skliper mentioned this issue Sep 2, 2020
Merged
@skliper skliper mentioned this issue Sep 2, 2020
Merged
astrogeco added a commit that referenced this issue Sep 4, 2020
@astrogeco
Merge pull request #829 from skliper/fix828-spacecraft-id-hex
965b11d 
Fix #828, Spacecraft ID sample set to historical value (0x42)
astrogeco added a commit that referenced this issue Sep 4, 2020
@astrogeco
Merge pull request #860 from skliper/fix828-spacecraft-id-hex
0bca6dc 
Fix #828, Spacecraft ID sample set to historical value (0x42)
@skliper skliper added this to the 6.8.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skliper skliper

Labels
bug build-system cFS-Bootes
Projects
None yet
Milestone
Bootes
Development

Successfully merging a pull request may close this issue.

Fix #828, Spacecraft ID sample set to historical value (0x42) skliper/cFE
2 participants
@skliper @astrogeco