-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #828, Spacecraft ID sample set to historical value (0x42) #829
Conversation
May want to consider this one for inclusion in Bootes... since the previous change (where it went to 42 decimal) could be considered a "breaking" change. There are toolchains that depend on this historical value. Although it is just in the sample config settings, so easy enough to fix. Just won't work "out of the box" for folks with an expectation that it didn't change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I say hotfix Bootes with this.
CCB 2020-08-26 - APPROVED, add to Bootes and tag rc2 |
Instructions for this merge:
|
I can rebase this on 6.8.x if you want. |
b15c4e5
to
1be664e
Compare
This one is good to go onto 6.8.x, I'll create the PR for 7.0 next. |
Describe the contribution
Fix #828 - set spacecraft ID in sample targets.cmake to 0x42
Testing performed
Nominal build and test
Expected behavior changes
Spacecraft ID back to historical value (some toolchains depend on it). Verified at PSP startup, reported as 66 (0x42).
System(s) tested on
Additional context
None
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC