Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardcode of spacecraft id to 42 in psp unit test stub #187

Closed
skliper opened this issue Aug 21, 2020 · 0 comments · Fixed by #188, #191 or #196
Closed

Hardcode of spacecraft id to 42 in psp unit test stub #187

skliper opened this issue Aug 21, 2020 · 0 comments · Fixed by #188, #191 or #196
Labels
bug Something isn't working
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Aug 21, 2020

Is your feature request related to a problem? Please describe.
Likely should be 0x42 since that's the historical sample setting. Not critical since this is just stub data, but easier to understand intent if the settings are consistent.

Describe the solution you'd like
Default spacecraft ID to the historical setting.

Describe alternatives you've considered
Some random value, or use CFE_SPACECRAFT_ID_VALUE

Additional context
nasa/cFE#710, nasa/cFE#828

Requester Info
Jacob Hageman - NASA/GSFC
skliper added a commit to skliper/PSP that referenced this issue Aug 21, 2020
@skliper
Fix nasa#187, Set stub spacecraft ID to historical value (0x42)
dfea5b3
@skliper skliper mentioned this issue Aug 21, 2020
Merged
@skliper skliper mentioned this issue Sep 2, 2020
Merged
astrogeco added a commit that referenced this issue Sep 3, 2020
@astrogeco
Merge pull request #188 from skliper/fix187-scid-historical-value-stub
37c9583 
Fix #187, Set stub spacecraft ID to historical value (0x42)
astrogeco added a commit that referenced this issue Sep 3, 2020
@astrogeco
Merge pull request #191 from skliper/fix187-scid-historical-value-stub
8ad7c15 
Fix #187, Set stub spacecraft ID to historical value (0x42)
yammajamma pushed a commit that referenced this issue Sep 17, 2020
@skliper @yammajamma
Fix #187, Set stub spacecraft ID to historical value (0x42)
fee2016
@yammajamma yammajamma mentioned this issue Sep 17, 2020
Merged
@astrogeco astrogeco added the bug Something isn't working label Oct 1, 2020
@astrogeco astrogeco added this to the 1.6.0 milestone Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Caelum
2 participants
@skliper @astrogeco