Skip to content

fix(release): preserve historical proof policy - #25

Merged
myagentdojo merged 2 commits into
mainfrom
codex/fix-historical-repair-proof
Aug 9, 2026
Merged

myagentdojo merged 2 commits into
mainfrom
codex/fix-historical-repair-proof

Conversation

@myagentdojo

@myagentdojo myagentdojo commented Aug 9, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • run the Bun platform compatibility matrix only for new publications
  • let historical repair continue through its candidate-owned prove:all suite when compatibility is intentionally skipped
  • contract-test the repair dependency path

Evidence

  • hosted repair run 31292193654 admitted v0.1.1 safely, then all four compatibility jobs failed because the historical candidate predates prove:runtime-platform
  • publication was skipped; no release state changed
  • bun test scripts/release-validate.test.ts scripts/prove-runtime-platform.test.ts (48 pass)
  • actionlint .github/workflows/release.yml
  • git diff --check

Summary by CodeRabbit

  • Bug Fixes

    • Improved release workflow reliability by preventing unnecessary compatibility checks during repair releases.
    • Ensured package creation waits for required release validation steps and runs correctly in both publish and repair modes.
  • Tests

    • Expanded workflow validation to verify compatibility and packaging behavior across release scenarios.

Copy link
Copy Markdown
Owner Author

@codex review

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 9, 2026 •

Copy link
Copy Markdown

Review Change Stack

Important

Review skipped

No new commits to review since the last review.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a5300d22-1343-4592-b274-46a420600069

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

The release workflow skips compatibility validation during repair mode and permits packaging after successful resolve and candidate jobs. Workflow tests validate publish and repair conditions.

Changes

Release workflow gating

Layer / File(s) Summary
Compatibility and package job conditions
.github/workflows/release.yml, scripts/release-validate.test.ts
Compatibility runs only in publish mode. Packaging runs in publish or repair mode when resolve and candidate succeed, and accepts skipped compatibility during repair mode. Tests verify these conditions.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the release workflow change that preserves the historical proof policy for repairs.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-historical-repair-proof

Comment @coderabbitai help to get the list of available commands.

@coderabbitai

coderabbitai Bot commented Aug 9, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@myagentdojo
myagentdojo temporarily deployed to hosted-canary-qualification August 9, 2026 03:24 — with GitHub Actions Inactive
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: 7d192c9a85

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Owner Author

@codex-gate approve 7d192c9 5229564436

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: 7d192c9a85

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 9, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 9, 2026 •

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@scripts/release-validate.test.ts`:
- Around line 350-353: Strengthen the release-gate assertions in the test around
compatibilityJob and packageJob to validate the complete dependency predicates,
not just individual fragments. Cover the publish and repair truth table,
ensuring compatibility runs only for publish and skipped compatibility is
accepted only for repair when resolve and candidate succeed, while failed or
canceled dependencies block packaging.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f52630b2-3672-4976-8dda-be832deb3a38

📥 Commits

Reviewing files that changed from the base of the PR and between 06f8454 and 7d192c9.

📒 Files selected for processing (2)
  • .github/workflows/release.yml
  • scripts/release-validate.test.ts

Comment thread scripts/release-validate.test.ts Outdated
@myagentdojo
myagentdojo temporarily deployed to hosted-canary-qualification August 9, 2026 03:47 — with GitHub Actions Inactive
@myagentdojo

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@myagentdojo

Copy link
Copy Markdown
Owner Author

@codex review

@coderabbitai

coderabbitai Bot commented Aug 9, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Already reviewed.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: edcddf6323

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@myagentdojo

Copy link
Copy Markdown
Owner Author

@codex-gate approve edcddf6 5229640148

@chatgpt-codex-connector

Copy link
Copy Markdown

To use Codex here, create an environment for this repo.

This branch was previously deployed

1 inactive deployment
hosted-canary-qualification — edcddf63 Deployed Aug 9, 2026 by myagentdojo via Qualify immutable hosted candidates #94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants